[jira] Commented: (SHINDIG-1090) Invalid URLs for break the request altogether

[Chirag Shah (JIRA)]

    [ 
https://issues.apache.org/jira/browse/SHINDIG-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860401#action_12860401
 ] 

Chirag Shah commented on SHINDIG-1090:
--------------------------------------

Looks like this was fixed inside PipelinedData.java

[snip]
      try {
        evaluatedHref = base.resolve(Uri.parse(hrefString));
      } catch (IllegalArgumentException e) {
        throw new ELException("bad Uri '" + hrefString + "' - " + 
e.getMessage(), e);
      }


> Invalid URLs for <os:HttpRequest> break the request altogether
> --------------------------------------------------------------
>
>                 Key: SHINDIG-1090
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1090
>             Project: Shindig
>          Issue Type: Bug
>          Components: Java
>            Reporter: Adam Winer
>            Assignee: Adam Winer
>            Priority: Minor
>
> An example we see today:
> IllegalArgumentException: URLDecoder: Incomplete trailing escape (%) pattern
> java.lang.IllegalArgumentException
> at java.net.URLDecoder.decode(Unknown Source)
> at org.apache.shindig.common.util.Utf8UrlCoder.decode(Utf8UrlCoder.java:41)
> at 
> org.apache.shindig.common.uri.UriBuilder.splitParameters(UriBuilder.java:244)
> at org.apache.shindig.common.uri.UriBuilder.setQuery(UriBuilder.java:139)
> at org.apache.shindig.common.uri.Uri.parse(Uri.java:94)
> at 
> org.apache.shindig.gadgets.spec.PipelinedData$HttpData.evaluate(PipelinedData.java:486)
> at 
> org.apache.shindig.gadgets.spec.PipelinedData.getBatch(PipelinedData.java:201)
> at 
> org.apache.shindig.gadgets.spec.PipelinedData.access$000(PipelinedData.java:54)
> at 
> org.apache.shindig.gadgets.spec.PipelinedData$BatchImpl.getNextBatch(PipelinedData.java:257)
> at 
> org.apache.shindig.gadgets.preload.PipelineExecutor.execute(PipelineExecutor.java:151)
> at 
> org.apache.shindig.gadgets.rewrite.PipelineDataGadgetRewriter.rewrite(PipelineDataGadgetRewriter.java:92)
> at org.apache.shindig.gadgets.render.HtmlRenderer.render(HtmlRenderer.java:94)
> at org.apache.shindig.gadgets.render.Renderer.render(Renderer.java:88)
> at 
> org.apache.shindig.gadgets.servlet.GadgetRenderingServlet.render(GadgetRenderingServlet.java:60)
> at 
> org.apache.shindig.gadgets.servlet.GadgetRenderingServlet.doGet(GadgetRenderingServlet.java:100)
> This should just be a 400 response for that data, not an uncaught exception.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.