[ 
https://issues.apache.org/jira/browse/SHINDIG-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869928#action_12869928
 ] 

Evgeny Bogdanov commented on SHINDIG-1324:
------------------------------------------

I believe you changed the way this part of code works: 
GadgetFeatureRegistry.php, line 83 ?

    if (Config::get('compress_javascript')) {
      $ret = JsMin::minify($ret);
      $featureCache->set(md5('features:'.$featureName.$isGadgetContext), $ret);
    }

if so, then changing Config::get('compress_javascript') into something (if url 
doesn't have a parameter "debug=1" )
would comply with java shindig.

> debug and nocache parameters are not supported in PHP shindig
> -------------------------------------------------------------
>
>                 Key: SHINDIG-1324
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1324
>             Project: Shindig
>          Issue Type: Bug
>          Components: PHP
>         Environment: PHP shindig
>            Reporter: Evgeny Bogdanov
>
> PHP shindig doesn't understand parameters for javascript urls 
> &debug=1&nocache=1
> To compress or not compress javascript is defined in the configuration 
> settings:
>   // Compress the inlined javascript, saves upto 50% of the document size
>   'compress_javascript' => true,
> I believe it should be done the same way as for Java Shindig, no?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to