Increase visibility of selected fields in
org.apache.shindig.gadgets.oauth.OAuthRequest to make subclassing easier
------------------------------------------------------------------------------------------------------------------
Key: SHINDIG-1359
URL: https://issues.apache.org/jira/browse/SHINDIG-1359
Project: Shindig
Issue Type: Improvement
Components: Java
Reporter: Jan Luehe
We are subclassing OAuthRequest and override its sanitizeAndSign method, which
references "accessorInfo", which currently has "private" scope in the
superclass.
This is forcing us to redefine and initialize "accessorInfo" in our subclass,
by copying this code from OAuthRequest#fetchNoThrow():
accessorInfo = fetcherConfig.getTokenStore().getOAuthAccessor(
realRequest.getSecurityToken(), realRequest.getOAuthArguments(),
clientState,
responseParams, fetcherConfig);
As a result of this, we also need to redefine "realRequest" in our subclass,
because it also has "private" scope in the superclass.
We might consider broadening the scope of some of the other fields of
OAuthRequest, but at a minimum, we should change the visibility of
"accessorInfo" and "realRequest" from "private" to "protected".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
