[
https://issues.apache.org/jira/browse/SHINDIG-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888808#action_12888808
]
Bastian Hofmann commented on SHINDIG-1387:
------------------------------------------
https://svn.apache.org/repos/asf/shindig/trunk/php/src/common/OAuthLookupService.php
has the $contenType parameter
https://svn.apache.org/repos/asf/shindig/trunk/php/src/common/sample/BasicOAuthLookupService.php
hasn't
if i understand chris' commit message correctly and if you look in the
ApiServlet which uses the LookupService you see that it is used like this:
$oauthLookupService = Config::get('oauth_lookup_service');
$oauthLookupService = new $oauthLookupService();
$token = $oauthLookupService->getSecurityToken($request, $appUrl,
$userId, $this->getContentType());
So that means the $contentType parameter should be added to the
BasicOAuthLookupService as well
https://svn.apache.org/repos/asf/shindig/trunk/php/src/social/servlet/ApiServlet.php
> Signature of getSecurityToken in BasicOAuthLookupService does not match base
> class OAuthLookupService
> -----------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1387
> URL: https://issues.apache.org/jira/browse/SHINDIG-1387
> Project: Shindig
> Issue Type: Bug
> Reporter: Bastian Hofmann
> Fix For: 2.0.0-RC1
>
>
> Patch:
> Index: php/src/common/sample/BasicOAuthLookupService.php
> ===================================================================
> 27c27
> < public function getSecurityToken($oauthRequest, $appUrl, $userId) {
> ---
> > public function getSecurityToken($oauthRequest, $appUrl, $userId,
> > $contentType) {
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
