[
https://issues.apache.org/jira/browse/SHINDIG-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059129#comment-13059129
]
[email protected] commented on SHINDIG-1555:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/991/#review957
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java
<https://reviews.apache.org/r/991/#comment2027>
Is there a reason why the new lines for these parameters changed? Or is
this the diff tool being dumb?
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java
<https://reviews.apache.org/r/991/#comment2028>
If we are going to add the @throws to the javadoc we might as well add the
GadgetException and say why these are being thrown
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java
<https://reviews.apache.org/r/991/#comment2029>
Make "POST" private static final
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java
<https://reviews.apache.org/r/991/#comment2030>
Why create a new string variable for post content? Can't we just do
postContent.getBytes() in the constructor of the ByteArrayInputStream?
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyServlet.java
<https://reviews.apache.org/r/991/#comment2032>
Do not catch Exception, I would rather you catch the specific exceptions
instead of the more general one
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyServlet.java
<https://reviews.apache.org/r/991/#comment2033>
This should probably be in a finally block
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyServletTest.java
<https://reviews.apache.org/r/991/#comment2034>
Couldn't you define this variable in the ServletInputStream?
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyServletTest.java
<https://reviews.apache.org/r/991/#comment2035>
It's ok to make is2 private right?
- Ryan
On 2011-07-01 18:50:42, Michael Brockhurst wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/991/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-07-01 18:50:42)
bq.
bq.
bq. Review request for Ryan Baxter and Stanton Sievers.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Implemented the function doPost for the shindig ProxyServlet class.
bq.
bq.
bq. This addresses bug SHINDIG-1555.
bq. https://issues.apache.org/jira/browse/SHINDIG-1555
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyServlet.java
1141997
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java
1141997
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyServletTest.java
1141997
bq.
bq. Diff: https://reviews.apache.org/r/991/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Created a gadget that made a post request from a proxy server using the
following lines of code:
bq.
bq. var proxyURL = gadgets.io.getProxyUrl("https://www.website.com";);
bq. var request = new XMLHttpRequest();
bq. request.open("POST", proxyURL, false);
bq.
bq.
bq. Thanks,
bq.
bq. Michael
bq.
bq.
> Shindig's ProxyServlet should implement doPost
> ----------------------------------------------
>
> Key: SHINDIG-1555
> URL: https://issues.apache.org/jira/browse/SHINDIG-1555
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 2.0.2
> Reporter: Stanton Sievers
> Labels: proxy
> Fix For: 3.0.0
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Shindig's ProxyServlet currently does not support HTTP POST. This
> improvement would be to augment the existing ProxyServlet to implement doPost
> as well as doGet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
