[
https://issues.apache.org/jira/browse/SHINDIG-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13083203#comment-13083203
]
[email protected] commented on SHINDIG-1567:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/982/#review1409
-----------------------------------------------------------
Ship it!
LGTM! Thanks
- Henry
On 2011-08-11 13:23:16, cheelan wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/982/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-08-11 13:23:16)
bq.
bq.
bq. Review request for shindig, Ryan Baxter, Stanton Sievers, and Dan Dumont.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is the reference implementation for the dynamic width OpenSocial spec
change:
bq.
http://code.google.com/p/opensocial-resources/issues/detail?id=1191&colspec=ID%20Type%20Container%20Stars%20Summary%20Status
bq.
bq. This change also incorporates the change posed here:
https://reviews.apache.org/r/974/
bq. That change is necessary in order for the rpc callback in Dynamic Width to
function properly.
bq.
bq.
bq. This addresses bug SHINDIG-1567.
bq. https://issues.apache.org/jira/browse/SHINDIG-1567
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/dynamicWidthTest.xml
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js
1147953
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.height/feature.xml
1147953
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/dynamic-height-util.js
1147953
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/feature.xml
1147953
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/taming.js
1147953
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height/feature.xml
1147953
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/dynamic-size-util.js
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/feature.xml
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/taming.js
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/dynamic-width-width.js
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/feature.xml
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/taming.js
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/dynamic-width.js
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/feature.xml
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/taming.js
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt
1147953
bq.
bq. Diff: https://reviews.apache.org/r/982/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested against Firefox 3.6, Chrome 12, Safari 5 in a custom container
bq.
bq.
bq. Thanks,
bq.
bq. cheelan
bq.
bq.
> Implement gadgets.window.adjustWidth
> ------------------------------------
>
> Key: SHINDIG-1567
> URL: https://issues.apache.org/jira/browse/SHINDIG-1567
> Project: Shindig
> Issue Type: New Feature
> Components: Javascript
> Affects Versions: 3.0.0
> Reporter: Stanton Sievers
> Labels: features, javascript
> Fix For: 3.0.0
>
>
> Shindig needs to implement the gadgets.window.adjustWidth API per the
> OpenSocial 2.0 spec:
> http://opensocial-resources.googlecode.com/svn/spec/2.0/Core-Gadget.xml#gadgets.window.adjustWidth
> https://reviews.apache.org/r/982/
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
