[
https://issues.apache.org/jira/browse/SHINDIG-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086960#comment-13086960
]
Hasan Ceylan commented on SHINDIG-1581:
---------------------------------------
Dear Henry,
As stated before, I cannot get the samples to work. Having said that, I tried
to test as best as I can by checking the scripts sent to browser in both
externalize-feature-libs is true / false cases.
As a side note, I noticed that the jsUrl in shindig.properties set to
"//%host%/....", note the missing http(s) part. Although I am sure there is a
reason for that, currently this is amongst the guilty parts the samples do not
work.
As I use git I create the patches from it. I tried to remove the header, if it
still doesn't work, you may need to mangle the header a bit manually (another
bug this time for eclipse egit team? :) )
Thanks again for your interest in the issue.
Regards,
Hasan Ceylan
> When default-forced-libs and externalize-feature-libs, feature resources are
> duplicated.
> ----------------------------------------------------------------------------------------
>
> Key: SHINDIG-1581
> URL: https://issues.apache.org/jira/browse/SHINDIG-1581
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.0.2
> Reporter: Hasan Ceylan
> Priority: Blocker
> Attachments: SHINDIG-1581-trunk.patch, SHINDIG-1581.patch
>
>
> For network performance we choose to set externalize-feature-libs to true to
> lower ifr response sizes. On the other hand we also have some
> default-forced-libs.
> We have discovered that in this case the external script tag inserted two
> times one for the default-forced-libs, other for the gadget features. With JS
> servlet being unaware of there are two separate requests, the transitive
> dependencies included twice, as a result of this, some of the core libraries
> included twice.
> This behavior can be tested with setting externalize-feature-libs to true on
> default java server and running sample-pubsub-2.html from browser.
> The correct implementation should combine the two library requests into one
> to avoid double-load.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira