[
https://issues.apache.org/jira/browse/SHINDIG-1597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13092978#comment-13092978
]
[email protected] commented on SHINDIG-1597:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1663/#review1679
-----------------------------------------------------------
Ship it!
LGTM looks like Henry committed this already. Please close the review and the
JIRA.
- Ryan
On 2011-08-25 22:20:42, li xu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1663/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-08-25 22:20:42)
bq.
bq.
bq. Review request for shindig, Paul Lindner, Henry Saputra, and Ryan Baxter.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. minor bug fix to inject hostProvider to JsonDbOpensocialSerivce
bq. Need to inject hostProvider to JsonDbOpensocialService
bq. @Inject(optional = true)
bq. public void setHostProvider( Provider<Authority> hostProvider) {
bq. this.hostProvider = hostProvider;
bq. }
bq.
bq.
bq. This addresses bug SHINDIG-1597.
bq. https://issues.apache.org/jira/browse/SHINDIG-1597
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java
1161655
bq.
bq. Diff: https://reviews.apache.org/r/1663/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. passed junit tests
bq.
bq.
bq. Thanks,
bq.
bq. li
bq.
bq.
> minor bug fix to inject hostProvider to JsonDbOpensocialSerivce
> ---------------------------------------------------------------
>
> Key: SHINDIG-1597
> URL: https://issues.apache.org/jira/browse/SHINDIG-1597
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 3.0.0
> Reporter: li xu
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: oauth.patch, patch0826
>
>
> Need to inject hostProvider to JsonDbOpensocialService
> @Inject(optional = true)
> public void setHostProvider( Provider<Authority> hostProvider) {
> this.hostProvider = hostProvider;
> }
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira