[
https://issues.apache.org/jira/browse/SHINDIG-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103911#comment-13103911
]
[email protected] commented on SHINDIG-1620:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1749/#review1870
-----------------------------------------------------------
One nit, I am not to fond of the feature name 'script-frame'. From the gadget
Dev point of view it's more of a script view than a frame.
- Ryan
On 2011-09-13 18:09:05, Dan Dumont wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1749/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-13 18:09:05)
bq.
bq.
bq. Review request for shindig, johnfargo, Ryan Baxter, Michael Hermanto,
Jason Chiang, Matthew Hatem, Stanton Sievers, Igor Belakovskiy, and Andrew
Davis.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Adding a new feature to shindig to support a shared-script-frame feature.
Gadgets can request that a view of itself be rendered before any other view is
rendered.
bq. The container will hide this gadget view (no-ui) and give the gadget
iframe a name so that other gadget views from the same gadget can reference it
and use it as a single script store.
bq.
bq.
bq. This addresses bug SHINDIG-1620.
bq. https://issues.apache.org/jira/browse/SHINDIG-1620
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shared-script-frame/taming.js
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shared-script-frame/shared-script-frame.js
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shared-script-frame/shared-script-frame-container.js
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js
1166716
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js
1166716
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js
1166716
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt
1166716
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shared-script-frame/feature.xml
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js
1166716
bq.
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/SharedScriptFrameDemo.xml
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/1749/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Dan
bq.
bq.
> Shared Script Frame feature
> ---------------------------
>
> Key: SHINDIG-1620
> URL: https://issues.apache.org/jira/browse/SHINDIG-1620
> Project: Shindig
> Issue Type: New Feature
> Reporter: Dan Dumont
>
> New feature to allow for better optimization of more complex gadgets
> consisting of multiple different views.
> A shared script frame is a place gadgets can load script code in, among other
> things.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
