[
https://issues.apache.org/jira/browse/SHINDIG-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104934#comment-13104934
]
[email protected] commented on SHINDIG-1569:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1211/#review1898
-----------------------------------------------------------
LGTM Dan. My one concern is that there is existing code that depends on the
old behavior. Are there any unit tests around this code? Can you think of any
way to figure out if there is any code that depends on the old behavior? Just
want to know how certain we are that this is not going to bite us.
- Ryan
On 2011-08-12 14:44:17, Dan Dumont wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1211/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-08-12 14:44:17)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. While debugging using a container cross-site from where shindig is hosted,
I ran into trouble using:
bq. config[osapi.container.ServiceConfig.API_PATH] = '/rpc';
bq. config[osapi.container.ServiceConfig.API_HOST] = // A url to a proxy on
the host server that points to the shindig server.
bq.
bq. I found that the osapi.container.Service.prototype.registerOsapiServices
function was defining methods that never ended up sticking, because other
methods would beat it to the punch.
bq. This resulted in the above settings never taking hold.
bq.
bq.
bq. This addresses bug SHINDIG-1569.
bq. https://issues.apache.org/jira/browse/SHINDIG-1569
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/osapi.base/osapi.js
1151610
bq.
bq. Diff: https://reviews.apache.org/r/1211/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested navigate gadget in a cross-hosted container environment (vanilla
web host loading CC from shindig server).
bq. Tested navigate gadget in SampleContainer (same host).
bq.
bq.
bq. Thanks,
bq.
bq. Dan
bq.
bq.
> Change osapi._registerMethods to 'last one in wins'
> ---------------------------------------------------
>
> Key: SHINDIG-1569
> URL: https://issues.apache.org/jira/browse/SHINDIG-1569
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Reporter: Dan Dumont
> Priority: Minor
>
> While debugging using a container cross-site from where shindig is hosted, I
> ran into trouble using:
> config[osapi.container.ServiceConfig.API_PATH] = '/rpc';
> config[osapi.container.ServiceConfig.API_HOST] = // A url to a proxy on the
> host server that points to the shindig server.
> I found that the osapi.container.Service.prototype.registerOsapiServices
> function was defining methods that never ended up sticking, because other
> methods would beat it to the punch.
> This resulted in the above settings never taking hold.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
