[
https://issues.apache.org/jira/browse/SHINDIG-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113056#comment-13113056
]
[email protected] commented on SHINDIG-1628:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2025/#review2031
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java
<https://reviews.apache.org/r/2025/#comment4580>
Is the only change here to remove this import? I assume it was unused?
Are you just being a good citizen? :)
- Ryan
On 2011-09-22 21:35:24, Dan Dumont wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2025/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-22 21:35:24)
bq.
bq.
bq. Review request for shindig, johnfargo, Ryan Baxter, and Stanton Sievers.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Sorry for the crazy diffs here. Much stuff has moved around.
bq. This is the cleanup part of the patch, I want a few good eyes first before
I move on to the feature work.
bq.
bq. Some highlights:
bq.
bq. * org.apache.shindig.gadgets.uri.DefaultIframeUriManager
bq. Nearly everything relating to locked domains has been moved to
org.apache.shindig.gadgets.LockedDomainService
bq. Removed validation on uri for locked domains from this class. It was
never actually used.
bq.
bq. * org.apache.shindig.gadgets.uri.ProxyUriBase
bq. Removed check for INVALID_DOMAIN, nothing in the code paths leading there
ever set that status.
bq.
bq. * org.apache.shindig.gadgets.uri.UriStatus
bq. Removed INVALID_DOMAIN, it was not used anymore. This class seems more
focused on caching anyway.
bq.
bq. * org.apache.shindig.gadgets.HashLockedDomainService
bq. Implemented new methods added to interface. Renamed some methods for
clarity and java convention.
bq. Augmented some existing implementation from code that used to be in
bq. org.apache.shindig.gadgets.uri.DefaultIframeUriManager
bq.
bq.
bq. This addresses bug SHINDIG-1628.
bq. https://issues.apache.org/jira/browse/SHINDIG-1628
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/HashLockedDomainService.java
1174376
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/LockedDomainService.java
1174376
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java
1174376
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java
1174376
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/ProxyUriBase.java
1174376
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/UriStatus.java
1174376
bq.
http://svn.apache.org/repos/asf/shindig/trunk/php/test/gadgets/ContainerConfigTest.php
1174376
bq. http://svn.apache.org/repos/asf/shindig/trunk/config/container.js
1174376
bq.
bq. Diff: https://reviews.apache.org/r/2025/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Dan
bq.
bq.
> Locked domain cleanup and shared-domain-locking feature
> -------------------------------------------------------
>
> Key: SHINDIG-1628
> URL: https://issues.apache.org/jira/browse/SHINDIG-1628
> Project: Shindig
> Issue Type: New Feature
> Components: Java
> Reporter: Dan Dumont
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
