[ 
https://issues.apache.org/jira/browse/SHINDIG-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113720#comment-13113720
 ] 

[email protected] commented on SHINDIG-1629:
--------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2038/#review2057
-----------------------------------------------------------

Ship it!


LGTM

Out of curiosity, how did you determine all of the uses?

- Stanton


On 2011-09-23 17:03:55, Ryan Baxter wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2038/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-09-23 17:03:55)
bq.  
bq.  
bq.  Review request for shindig and johnfargo.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  The uses elements can be used to secure which RPC endpoints gadgets will 
be allowed to call. The export elements are not used currently but we should 
add them for completeness.
bq.  
bq.  
bq.  This addresses bug SHINDIG-1629.
bq.      https://issues.apache.org/jira/browse/SHINDIG-1629
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    
http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/opensocial-payment/feature.xml
 1174813 
bq.    
http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/feature.xml
 1174813 
bq.    
http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/wave/feature.xml
 1174813 
bq.    
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml
 1174813 
bq.    
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/auth-refresh/feature.xml
 1174813 
bq.    
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/feature.xml
 1174813 
bq.    
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height/feature.xml
 1174813 
bq.    
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/feature.xml
 1174813 
bq.    
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/feature.xml
 1174813 
bq.    
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/feature.xml
 1174813 
bq.    
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/opensocial-jsonrpc/feature.xml
 1174813 
bq.    
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/opensocial-reference/feature.xml
 1174813 
bq.    
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/osapi/feature.xml
 1174813 
bq.    
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/pubsub/feature.xml
 1174813 
bq.    
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/rpc/feature.xml
 1174813 
bq.    
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/feature.xml
 1174813 
bq.    
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/setprefs/feature.xml
 1174813 
bq.    
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/settitle/feature.xml
 1174813 
bq.    
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shared-script-frame/feature.xml
 1174813 
bq.    
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shindig.container/feature.xml
 1174813 
bq.    
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/views/feature.xml
 1174813 
bq.  
bq.  Diff: https://reviews.apache.org/r/2038/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Ran unit tests
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ryan
bq.  
bq.



> Add <uses> and <export type="rpc"> elements to features which call or 
> register RPC endpoints
> --------------------------------------------------------------------------------------------
>
>                 Key: SHINDIG-1629
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1629
>             Project: Shindig
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: Ryan Baxter
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> The uses elements can be used to secure which RPC endpoints gadgets will be 
> allowed to call.  The export elements are not used currently but we should 
> add them for completeness.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to