[
https://issues.apache.org/jira/browse/SHINDIG-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115750#comment-13115750
]
jirapos...@reviews.apache.org commented on SHINDIG-1624:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1947/#review2092
-----------------------------------------------------------
A few general comments in addition to the ones below.
In several files there are white spaces, please go through and remove these,
its best to start with a clean slate.
My major concern here is testing. It looks like you added a lot of new code
but I see a little in the way of unit tests for it. Also in the unit tests you
did modify I did not see any new tests exercising the new code paths.
There is a lot of code here and it would be best to get as many eyes on this as
possible.
/trunk/config/oauth2.json
<https://reviews.apache.org/r/1947/#comment4737>
If there any way we can combine this file with the oauth file that already
exists in shindig. Does that make sense? I would rather not have another file
which does the same thing.
/trunk/config/oauth2.json
<https://reviews.apache.org/r/1947/#comment4736>
We probably want to point to the section in the spec, not the issue.
/trunk/content/samplecontainer/examples/oauth2/oauth2_facebook.xml
<https://reviews.apache.org/r/1947/#comment4738>
It looks like this gadget is using jquery but I don't see a script import
for it....
/trunk/content/samplecontainer/examples/oauth2/oauth2_windowslive.xml
<https://reviews.apache.org/r/1947/#comment4739>
The tabs here look to be off, should be 2 spaces
/trunk/content/samplecontainer/examples/oauth2/shindig_authorization.xml
<https://reviews.apache.org/r/1947/#comment4740>
Is this neccessary to point out ideally this the oauth2 provider patch will
be there
/trunk/content/samplecontainer/examples/oauth2/shindig_authorization.xml
<https://reviews.apache.org/r/1947/#comment4741>
again not sure where the jquery is coming from
/trunk/java/common/conf/shindig.properties
<https://reviews.apache.org/r/1947/#comment4742>
Comments on what these properties do would be good
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/config/XhrwrapperConfigContributor.java
<https://reviews.apache.org/r/1947/#comment4743>
Log the exception
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Request.java
<https://reviews.apache.org/r/1947/#comment4745>
Nit: Might help to break this out into separate methods to make this cleaner
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Request.java
<https://reviews.apache.org/r/1947/#comment4746>
Nit: Might help to break this out into separate methods to make this cleaner
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Request.java
<https://reviews.apache.org/r/1947/#comment4747>
Any need to check for null here?
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Request.java
<https://reviews.apache.org/r/1947/#comment4748>
Could we just handle this exception in the outer try?
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Request.java
<https://reviews.apache.org/r/1947/#comment4749>
Any need to check for null here?
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Request.java
<https://reviews.apache.org/r/1947/#comment4750>
Use Maps.newHashMap(...)
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java
<https://reviews.apache.org/r/1947/#comment4751>
It would be nice if it is at all possible to use the existing oauth store
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/GadgetOAuth2TokenStore.java
<https://reviews.apache.org/r/1947/#comment4752>
spacing here
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/GadgetOAuth2TokenStore.java
<https://reviews.apache.org/r/1947/#comment4753>
It would be great if you could javadoc these public methods
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/GadgetOAuth2TokenStore.java
<https://reviews.apache.org/r/1947/#comment4754>
Document the exception
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/GadgetOAuth2TokenStore.java
<https://reviews.apache.org/r/1947/#comment4755>
Log the exception
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Accessor.java
<https://reviews.apache.org/r/1947/#comment4757>
Please make sure the javadoc is complete
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Arguments.java
<https://reviews.apache.org/r/1947/#comment4758>
Make sure the javadoc is complete
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Arguments.java
<https://reviews.apache.org/r/1947/#comment4759>
I believe you can use the Maps API to create a new TreeMap
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Error.java
<https://reviews.apache.org/r/1947/#comment4763>
Make sure the javadoc is complete
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Error.java
<https://reviews.apache.org/r/1947/#comment4760>
At the very least you probably want to log this exception.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Message.java
<https://reviews.apache.org/r/1947/#comment4765>
Make sure there are descriptions in the javadoc
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Module.java
<https://reviews.apache.org/r/1947/#comment4766>
Log this exception
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Module.java
<https://reviews.apache.org/r/1947/#comment4767>
Log this exception
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2RequestException.java
<https://reviews.apache.org/r/1947/#comment4768>
Make sure the javadoc is complete
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2ResponseParams.java
<https://reviews.apache.org/r/1947/#comment4769>
Make sure the javadoc is complete
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2ResponseParams.java
<https://reviews.apache.org/r/1947/#comment4770>
Should use a StringBuffer
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Store.java
<https://reviews.apache.org/r/1947/#comment4771>
what does this return?
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Token.java
<https://reviews.apache.org/r/1947/#comment4772>
Make sure the javadoc is complete
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Utils.java
<https://reviews.apache.org/r/1947/#comment4773>
Does this belong in the commons project?
Make sure the javadoc is complete
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Utils.java
<https://reviews.apache.org/r/1947/#comment4774>
Use the Maps API
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Utils.java
<https://reviews.apache.org/r/1947/#comment4777>
Should we check the list's size before accessing any of the elements in it?
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Utils.java
<https://reviews.apache.org/r/1947/#comment4778>
Should we check the list's size before accessing any of the elements in it?
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Utils.java
<https://reviews.apache.org/r/1947/#comment4780>
Log this exception
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/AuthorizationEndpointResponseHandler.java
<https://reviews.apache.org/r/1947/#comment4781>
Make sure the javadoc is complete
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/ClientAuthenticationHandler.java
<https://reviews.apache.org/r/1947/#comment4784>
Make sure the javadoc is complete
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/GrantRequestHandler.java
<https://reviews.apache.org/r/1947/#comment4785>
Make sure the javadoc is complete
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/OAuth2HandlerError.java
<https://reviews.apache.org/r/1947/#comment4788>
Make sure the javadoc is complete
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/ResourceRequestHandler.java
<https://reviews.apache.org/r/1947/#comment4789>
Make sure the javadoc is complete
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/TokenEndpointResponseHandler.java
<https://reviews.apache.org/r/1947/#comment4790>
Make sure the javadoc is complete
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/BearerTokenHandler.java
<https://reviews.apache.org/r/1947/#comment4792>
Use the Maps API
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/ClientCredentialsGrantTypeHandler.java
<https://reviews.apache.org/r/1947/#comment4793>
Use the Maps API
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/CodeAuthorizationResponseHandler.java
<https://reviews.apache.org/r/1947/#comment4794>
Use the Maps API
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/CodeGrantTypeHandler.java
<https://reviews.apache.org/r/1947/#comment4796>
Use the Maps API
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/MACTokenHandler.java
<https://reviews.apache.org/r/1947/#comment4798>
NIT: Might help to have a helper class for this to make this code cleaner
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/MACTokenHandler.java
<https://reviews.apache.org/r/1947/#comment4800>
NIT: There are alot of params here, consider making a POJO object and
passing that in.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/TokenAuthorizationResponseHandler.java
<https://reviews.apache.org/r/1947/#comment4805>
Is the spec vague about the content type? Why does Facebook and Google
have two different content types?
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Cache.java
<https://reviews.apache.org/r/1947/#comment4806>
Make sure javadoc is complete
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Client.java
<https://reviews.apache.org/r/1947/#comment4808>
Make sure the javadoc is complete
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Encrypter.java
<https://reviews.apache.org/r/1947/#comment4809>
Make sure the javadoc is compelte
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Persister.java
<https://reviews.apache.org/r/1947/#comment4810>
Make sure the javadoc is complete
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2TokenPersistence.java
<https://reviews.apache.org/r/1947/#comment4811>
Use the Maps API
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2TokenPersistence.java
<https://reviews.apache.org/r/1947/#comment4812>
Cleaner if you do &&
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java
<https://reviews.apache.org/r/1947/#comment4817>
Want to log these exceptions
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java
<https://reviews.apache.org/r/1947/#comment4818>
Use the Maps API
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java
<https://reviews.apache.org/r/1947/#comment4819>
Remove this
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java
<https://reviews.apache.org/r/1947/#comment4820>
Remove this
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java
<https://reviews.apache.org/r/1947/#comment4821>
Remove this
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/OAuth2GadgetBinding.java
<https://reviews.apache.org/r/1947/#comment4822>
Add Javadoc
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/OAuth2Provider.java
<https://reviews.apache.org/r/1947/#comment4824>
Add Javadoc
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/sample/BasicOAuth2Message.java
<https://reviews.apache.org/r/1947/#comment4828>
Not sure we want to call out facebook
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/OAuth2CallbackServlet.java
<https://reviews.apache.org/r/1947/#comment4834>
Could you break here after you set foundHandler to true
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/OAuth2CallbackServlet.java
<https://reviews.apache.org/r/1947/#comment4836>
Would it be better to just have a constructor where there are injected
instead of just having the default constructor?
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/OAuth2Service.java
<https://reviews.apache.org/r/1947/#comment4839>
Make sure Javadoc is complete
Is there any code we can share between the OAuth2 service and the OAuth1
service?
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/OAuth2Spec.java
<https://reviews.apache.org/r/1947/#comment4840>
Make sure the Javadoc is complete
Can we share any code between the OAuth2 spec and the OAuth1 spec?
- Ryan
On 2011-09-23 19:54:08, li xu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1947/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-23 19:54:08)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. OAuth 2.0 client implementation in Apache Shindig from Adam Clarke, Eric
Woods, Jeff Hoy, Li Xu and Matthew Marum.
bq.
bq.
bq. Documentation wiki:
http://docs.opensocial.org/display/OSD/OAuth+2.0+Consumer+Implementation+in+Apache+Shindig
bq.
bq.
bq. JIRA issue: https://issues.apache.org/jira/browse/SHINDIG-1624
bq.
bq. OAuth2 test gadgets are added to common container test page and can be
tested by using
bq. http://localhost:8080/samplecontainer/examples/commoncontainer/index.html
bq.
bq. You will need OAuth2 service provider implementation to test following two
gadgets:
bq. OAuth2 demo with Shindig Provider (Authorization Code)
bq. OAuth2 demo with Shindig Provider (Client credential )
bq.
bq. You will need to have your own google/facebook client to test following
two gadgets
bq. OAuth2 demo with Google Provider
bq. OAuth2 demo with Facebook Provider
bq. Once it's registered with Google/Facebook, you can register the
client-id/pwd under
bq. /config/oauth2.json
bq.
bq.
bq. This addresses bug shindig-1624.
bq. https://issues.apache.org/jira/browse/shindig-1624
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/config/oauth2.json PRE-CREATION
bq.
/trunk/content/samplecontainer/examples/commoncontainer/gadgetCollections.json
1173772
bq. /trunk/content/samplecontainer/examples/oauth2/oauth2_facebook.xml
PRE-CREATION
bq. /trunk/content/samplecontainer/examples/oauth2/oauth2_google.xml
PRE-CREATION
bq. /trunk/content/samplecontainer/examples/oauth2/oauth2_windowslive.xml
PRE-CREATION
bq. /trunk/content/samplecontainer/examples/oauth2/shindig_authorization.xml
PRE-CREATION
bq.
/trunk/content/samplecontainer/examples/oauth2/shindig_client_credentials.xml
PRE-CREATION
bq. /trunk/features/src/main/javascript/features/core.io/io.js 1173772
bq.
/trunk/features/src/main/javascript/features/shindig.xhrwrapper/xhrwrapper.js
1173772
bq. /trunk/java/common/conf/shindig.properties 1173772
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AuthType.java
1173772
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/config/XhrwrapperConfigContributor.java
1173772
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java
1173772
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultRequestPipeline.java
1173772
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java
1173772
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Accessor.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Request.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/GadgetOAuth2TokenStore.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Accessor.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Arguments.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Error.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2FetcherConfig.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2GadgetContext.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Message.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Module.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Request.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2RequestException.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2ResponseParams.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Store.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Token.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Utils.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/AuthorizationEndpointResponseHandler.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/ClientAuthenticationHandler.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/GrantRequestHandler.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/OAuth2HandlerError.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/ResourceRequestHandler.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/TokenEndpointResponseHandler.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/BasicAuthenticationHandler.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/BearerTokenHandler.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/ClientCredentialsGrantTypeHandler.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/CodeAuthorizationResponseHandler.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/CodeGrantTypeHandler.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/MACTokenHandler.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/OAuth2HandlerModule.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/StandardAuthenticationHandler.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/TokenAuthorizationResponseHandler.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Cache.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2CacheException.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Client.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Encrypter.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2EncryptionException.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2PersistenceException.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Persister.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2TokenPersistence.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/InMemoryCache.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/NoOpEncrypter.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/OAuth2GadgetBinding.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/OAuth2PersistenceModule.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/OAuth2Provider.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/sample/BasicOAuth2Message.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/sample/OAuth2MessageModule.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/preload/HttpPreloader.java
1173772
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/ProxyRenderer.java
1173772
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HttpRequestHandler.java
1173772
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java
1173772
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/OAuth2CallbackServlet.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/ModulePrefs.java
1173772
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/OAuth2Service.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/OAuth2Spec.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/resources/org/apache/shindig/gadgets/oauth2/resource.properties
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/resources/org/apache/shindig/gadgets/oauth2/resource_en_US.properties
PRE-CREATION
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/AuthTypeTest.java
1173772
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/DefaultInvalidationServiceTest.java
1173772
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/DefaultRequestPipelineTest.java
1173772
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/RewriteModuleTest.java
1173772
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/StyleTagProxyEmbeddedUrlsVisitorTest.java
1173772
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/tags/TemplateBasedTagHandlerTest.java
1173772
bq. /trunk/java/server/pom.xml 1173772
bq. /trunk/java/server/src/main/webapp/WEB-INF/web.xml 1173772
bq.
/trunk/java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndServer.java
1173772
bq.
bq. Diff: https://reviews.apache.org/r/1947/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Yes, passed all JUnit tests with mantis build. tested with new OAuth2 demo
pages.
bq.
bq.
bq. Thanks,
bq.
bq. li
bq.
bq.
> OAuth 2.0 Consumer Java implementation for Shindig 3.0
> ------------------------------------------------------
>
> Key: SHINDIG-1624
> URL: https://issues.apache.org/jira/browse/SHINDIG-1624
> Project: Shindig
> Issue Type: Sub-task
> Components: Java
> Affects Versions: 3.0.0
> Reporter: Adam Clarke
> Fix For: 3.0.0
>
> Attachments: 20110921
>
> Original Estimate: 1,344h
> Remaining Estimate: 1,344h
>
> Developing an extensible OAuth 2.0 component for Shindig 3.0.0 tested against
> Google, Facebook and the Shindig Provider developed by Matt and Eric.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
