[
https://issues.apache.org/jira/browse/SHINDIG-1631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115830#comment-13115830
]
Fabrice edited comment on SHINDIG-1631 at 9/27/11 7:25 PM:
-----------------------------------------------------------
It might help to mention Adjust Height worked until August. There were several
commits regarding Adjusting Height and Width on that month... So it must have
gotten broken in the middle of August.
Revision : #1158921 or #1157210 are probably what caused this feature to not
work on third party website.
was (Author: soloren2001):
It might help to mention Adjust Height worked until August. There were
several commits regarding Adjusting Height and Width on that month...
> Adjust Height doesn't work in Thrid Paty website with IE and Firefox
> --------------------------------------------------------------------
>
> Key: SHINDIG-1631
> URL: https://issues.apache.org/jira/browse/SHINDIG-1631
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Environment: Firefox (tested with 5 and 6) and Internet Explorer
> (tested with 7, 8 and 9)
> It works with Chrome / Safari.
> Reporter: Fabrice
> Labels: api-change, javascript, patch
> Original Estimate: 8m
> Remaining Estimate: 8m
>
> Gadgets API and Open Social have a function for adjusting height:
> gadgets.window.adjustHeight()
> This function is not working on all browsers AND when called from thrid party
> website. On iGoogle it will work for all browsers (my understanding is that
> in this case it works because it is taking advantages of "views" instead).
> To view the bug, I embeded a gadget on this third party website:
> http://youfoot.weebly.com/ (open with Firefox or IE, and click "Expand" >
> the gagdet is truncated)
> The code is also posted on the same page. It's really a very simple code to
> test adjusting height: gadgets.window.adjustHeight()
> If you run this code in Google Gadget Checker to debug it it shows that the
> API is called but it doesn't see the function!
> Gadget Checker is available here:
> http://www.google.com/ig/adde?moduleurl=www.google.com/ig/modules/codechecker/codechecker.xml
> The error returned is:
> WARNING Unused features
> The gadget doesn't appear to use the dynamic-height feature, although it
> requests it.
> Recommendation: Consider removing this line, so your gadget doesn't contain
> unnecessary javascript.
> About the code: some may think the code is work. We didn't write it, this is
> a very basic code that Takashi Matsuo wrote in this post
> (http://groups.google.com/group/Google-Gadgets-API/browse_thread/thread/2641fd314290e47a)
> unfortunately he never responded and the code he gave he only tested in
> iGoogle and concluded that it worked. But his code doesn't work when the
> gadget is embeded in Third Party website. Afetr we didn't hear from him
> again...
> We've tried other syntax (like the deprecated function from 2008) and many
> other variations, as well as complete work-arounds > it's simply broken.
> Is this a Shindig issue: I didn't think this was. Because, in this case we
> want to embed this on a Third Party website which is not Open Social.
> However, having exchanged emails with Mark Weitzel (president of Open Social)
> he concluded:
> "adjustHeight is an API that's part of the spec. The implementation is in
> apache shindig. If this api doesn't actually work, it's likely a problem in
> the implementation--that's shindig."
> This is why I am posting this here...
> Priority: I am putting "Major" only (Major loss of function.) but this is
> the first thing we tested before we choose to use Gadgets/OpenSocial. It's
> critical to the usage of the Gadgets in term of UI. So to me it's "Blocker"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
