[
https://issues.apache.org/jira/browse/SHINDIG-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125272#comment-13125272
]
[email protected] commented on SHINDIG-1638:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2345/#review2513
-----------------------------------------------------------
Ship it!
+1
- Henry
On 2011-10-11 18:40:09, Michael Beaver wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2345/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-11 18:40:09)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. As part of the release cycle in our development group, we asked IBM
Information Development to review and edit the log messages in use by shindig.
They fixed some grammatical mistakes, typos in field names, and provided
improved wording in messages based on their guidelines for word usage and
clarity of message content. The attached patch file contains these updates that
we would like to have committed into the shindig base. Additionally, we are
pushing the messages through our various translation centers and will soon be
providing a follow-on patch that contains the NLS versions of the properties
files for the base languages we support.
bq.
bq. This impacts the following files: resource.properties,
resource_en_US.properties, MessageKeys.java, XmlUtil.java,
FeatureResourceLoader.java, and ApiServlet.java
bq.
bq.
bq. This addresses bug SHINDIG-1638.
bq. https://issues.apache.org/jira/browse/SHINDIG-1638
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
/trunk/java/common/src/main/java/org/apache/shindig/common/logging/i18n/MessageKeys.java
1178236
bq.
/trunk/java/common/src/main/java/org/apache/shindig/common/xml/XmlUtil.java
1159473
bq.
/trunk/java/common/src/main/java/org/apache/shindig/protocol/ApiServlet.java
1159473
bq.
/trunk/java/common/src/main/resources/org/apache/shindig/common/logging/i18n/resource.properties
1178236
bq.
/trunk/java/common/src/main/resources/org/apache/shindig/common/logging/i18n/resource_en_US.properties
1178236
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/features/FeatureResourceLoader.java
1178431
bq.
bq. Diff: https://reviews.apache.org/r/2345/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Michael
bq.
bq.
> Improvements to shindig log messages
> ------------------------------------
>
> Key: SHINDIG-1638
> URL: https://issues.apache.org/jira/browse/SHINDIG-1638
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 3.0.0
> Environment: All
> Reporter: Michael Beaver
> Priority: Minor
> Labels: patch
> Fix For: 3.0.0
>
> Attachments: logging-edits.patch
>
>
> As part of the release cycle in our development group, we asked IBM
> Information Development to review and edit the log messages in use by
> shindig. They fixed some grammatical mistakes, typos in field names, and
> provided improved wording in messages based on their guidelines for word
> usage and clarity of message content. The attached patch file contains these
> updates that we would like to have committed into the shindig base.
> Additionally, we are pushing the messages through our various translation
> centers and will soon be providing a follow-on patch that contains the NLS
> versions of the properties files for the base languages we support.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira