[ 
https://issues.apache.org/jira/browse/SHINDIG-1640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125928#comment-13125928
 ] 

[email protected] commented on SHINDIG-1640:
--------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2358/
-----------------------------------------------------------

Review request for shindig.


Summary
-------

The Media.xml gadget directly calls dojo.addOnLoad(init) in order to workaround 
an issue with tundra.css instead of wrapping it in a call to 
gadgets.util.registerOnLoadHandler(). This results in multiple instances of the 
gadget not being supported when rendering in IE8. Removing the direct call to 
dojo.addOnLoad and wrapping it in gadgets.util.registerOnLoadHandler fixes this 
issue, and the tundra.css issue no longer appears.


This addresses bug SHINDIG-1640.
    https://issues.apache.org/jira/browse/SHINDIG-1640


Diffs
-----

  /trunk/content/samplecontainer/examples/media/Media.xml 1178561 

Diff: https://reviews.apache.org/r/2358/diff


Testing
-------


Thanks,

Michael


                
> The sample Media.xml gadget does not support multiple instances in IE8
> ----------------------------------------------------------------------
>
>                 Key: SHINDIG-1640
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1640
>             Project: Shindig
>          Issue Type: Bug
>          Components: Javascript 
>    Affects Versions: 3.0.0
>         Environment: IE8
>            Reporter: Michael Beaver
>            Priority: Minor
>             Fix For: 3.0.0
>
>         Attachments: ie8-multiple-instances.patch
>
>
> The Media.xml gadget directly calls dojo.addOnLoad(init) in order to 
> workaround an issue with tundra.css instead of wrapping it in a call to 
> gadgets.util.registerOnLoadHandler().  This results in multiple instances of 
> the gadget not being supported when rendering in IE8.  Removing the direct 
> call to dojo.addOnLoad and wrapping it in gadgets.util.registerOnLoadHandler 
> fixes this issue, and the tundra.css issue no longer appears.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to