[
https://issues.apache.org/jira/browse/SHINDIG-1627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126064#comment-13126064
]
[email protected] commented on SHINDIG-1627:
--------------------------------------------------------
bq. On 2011-10-12 19:10:08, Paul Lindner wrote:
bq. >
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/service.js,
line 36
bq. > <https://reviews.apache.org/r/2348/diff/1/?file=49451#file49451line36>
bq. >
bq. > for readability can you assign these to local variables. Also what
happens if the regex fails to match?
bq. >
These are local variables within the osapi.container.Service closure.
They are not added on to this, because they should not be public.
The old default host is included if the container is not injected and no
host|path was provided. If something is injected or provided and the format is
not expected, bad things will happen. (JS error, service init failure)
I suspect that it was always the case though that things would not work right
if incorrect values were supplied.
- Dan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2348/#review2537
-----------------------------------------------------------
On 2011-10-11 19:00:14, Dan Dumont wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2348/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-11 19:00:14)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Should now be using the defaults as they were injected if not provided
explicitly through the common container config.
bq.
bq.
bq. This addresses bug SHINDIG-1627.
bq. https://issues.apache.org/jira/browse/SHINDIG-1627
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/service.js
1181802
bq.
bq. Diff: https://reviews.apache.org/r/2348/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Doug, Li, or anyone else interested...
bq.
bq. I know it's been a while coming, but I've been really busy. Could you
please test this small patch to see if it fixes the problem you guys were
having?
bq.
bq.
bq. Thanks,
bq.
bq. Dan
bq.
bq.
> When running with a non-root context, RPC calls are still being made to /rpc
> unless overridden with config
> ----------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1627
> URL: https://issues.apache.org/jira/browse/SHINDIG-1627
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Doug Davies
> Attachments: upstream.patch
>
>
> From Dan Dumont:
> The problem before is that '/rpc' was always registered. Always. It just
> never stuck because the service had already been registered.
> My change (SHINDIG-1569) changed that so it could be overridden by the config
> (necessary
> for cross domain container loading).
> Now /rpc is taking hold, overriding the previously set service. I didn't
> see this because we typically do not deploy on non-root contexts.
> So the workaround is to specify the path in the config, but I think there
> should be a JIRA for this so that we don't hardcode the default '/rpc' but
> instead somehow use the value that was used to register the service first.
> Or not register the service at all if the path/host has not been specified
> in the config.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
