[
https://issues.apache.org/jira/browse/SHINDIG-1639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126162#comment-13126162
]
[email protected] commented on SHINDIG-1639:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2367/
-----------------------------------------------------------
Review request for Paul Lindner, Henry Saputra, Ryan Baxter, and Eric Woods.
Summary
-------
Several classes contains "@Override" annotation which fails the build with
Java1.5.
Java1.5 compiler doesn't allow @Override annotation on implemented interface
methods. JAVA1.6 compiler does support that.
Just removed these @Override.
This addresses bug shindig-1639.
https://issues.apache.org/jira/browse/shindig-1639
Diffs
-----
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/GadgetAdminModule.java
1182052
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/BasicGadgetAdminStoreTest.java
1182052
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/RendererTest.java
1182052
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManagerTest.java
1182052
Diff: https://reviews.apache.org/r/2367/diff
Testing
-------
passed junit test
Thanks,
li
> build break with jvm1.5
> -----------------------
>
> Key: SHINDIG-1639
> URL: https://issues.apache.org/jira/browse/SHINDIG-1639
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 3.0.0
> Environment: all
> Reporter: li xu
> Priority: Minor
> Labels: patch
> Fix For: 3.0.0
>
> Attachments: remove_override.patch
>
>
> Several classes contains "@Override" annotation which fails the build with
> Java1.5.
> Java1.5 compiler doesn't allow @Override annotation on implemented interface
> methods. JAVA1.6 compiler does support that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
