[
https://issues.apache.org/jira/browse/SHINDIG-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127658#comment-13127658
]
[email protected] commented on SHINDIG-1632:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2052/#review2587
-----------------------------------------------------------
/trunk/content/samplecontainer/examples/conservcontainer/index.html
<https://reviews.apache.org/r/2052/#comment5817>
remove whitespace
/trunk/content/samplecontainer/examples/conservcontainer/index.html
<https://reviews.apache.org/r/2052/#comment5818>
+18 seems a little fragile. Why not define /conservcontainer/ as a var and
then get the length of the string
/trunk/content/samplecontainer/examples/conservcontainer/index.html
<https://reviews.apache.org/r/2052/#comment5819>
remove the white space
/trunk/content/samplecontainer/examples/conservcontainer/index.html
<https://reviews.apache.org/r/2052/#comment5820>
remove the white space and make sure it lines up
- Ryan
On 2011-10-12 20:54:19, li xu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2052/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-12 20:54:19)
bq.
bq.
bq. Review request for shindig, Paul Lindner, Henry Saputra, and Ryan Baxter.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The fix will set up API patch when common container is created in these
sample pages.
bq.
bq. var testConfig = testConfig || {};
bq. testConfig[osapi.container.ServiceConfig.API_PATH] = contextRoot + '/rpc';
bq. var CommonContainer = new osapi.container.Container(testConfig);
bq.
bq. also includes other minor cleanup.
bq.
bq.
bq. This addresses bug SHINDIG-1632.
bq. https://issues.apache.org/jira/browse/SHINDIG-1632
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/content/samplecontainer/examples/conservcontainer/index.html
1182418
bq.
bq. Diff: https://reviews.apache.org/r/2052/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. passed maven build.
bq.
bq.
bq. Thanks,
bq.
bq. li
bq.
bq.
> EE and conservContainer page doesn't run with context root other than Root
> --------------------------------------------------------------------------
>
> Key: SHINDIG-1632
> URL: https://issues.apache.org/jira/browse/SHINDIG-1632
> Project: Shindig
> Issue Type: Bug
> Components: Website
> Affects Versions: 3.0.0
> Reporter: li xu
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: 20111012_selection_action.patch
>
>
> Embedded experience sample page and Action/Selection sample doesnt' run out
> of box if shindig is deployed with a context root.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
