[
https://issues.apache.org/jira/browse/SHINDIG-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129919#comment-13129919
]
[email protected] commented on SHINDIG-1643:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2425/#review2653
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/ContainerAdminData.java
<https://reviews.apache.org/r/2425/#comment5971>
else if, to avoid checks if the 1st one matched.
- Dan
On 2011-10-18 18:13:24, Ryan Baxter wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2425/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-18 18:13:24)
bq.
bq.
bq. Review request for shindig and Dan Dumont.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. If there is a gadget in the admin store, for example
http://foo.com/gadget.xml and we try to render http://foo.com:80/gadget.xml
shindig does not think http://foo.com:80/gadget.xml is the same as
http://foo.com/gadget.xml are the same gadget so it does not think the gadget
should be allowed to render.
bq.
bq.
bq. This addresses bug SHINDIG-1643.
bq. https://issues.apache.org/jira/browse/SHINDIG-1643
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/ContainerAdminData.java
1185758
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/BasicGadgetAdminStoreTest.java
1185758
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/ContainerAdminDataTest.java
1185758
bq.
bq. Diff: https://reviews.apache.org/r/2425/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated unit tests to test new functionality
bq.
bq.
bq. Thanks,
bq.
bq. Ryan
bq.
bq.
> Gadget Admin Code Does Not Take Into Account Ports In Gadget URLs
> -----------------------------------------------------------------
>
> Key: SHINDIG-1643
> URL: https://issues.apache.org/jira/browse/SHINDIG-1643
> Project: Shindig
> Issue Type: Bug
> Reporter: Ryan Baxter
> Fix For: 3.0.0
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> If there is a gadget in the admin store, for example
> http://foo.com/gadget.xml and we try to render http://foo.com:80/gadget.xml
> shindig does not think http://foo.com:80/gadget.xml is the same as
> http://foo.com/gadget.xml are the same gadget so it does not think the gadget
> should be allowed to render.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
