[
https://issues.apache.org/jira/browse/SHINDIG-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133069#comment-13133069
]
[email protected] commented on SHINDIG-1648:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2527/#review2761
-----------------------------------------------------------
Ship it!
Committed revision 1187546.
There seems to be a bunch of duplicate code between the gadgets, maybe you
should think about abstracting the comment code out so you dont have to make
changes in 2 places.
- Ryan
On 2011-10-21 16:26:52, Jason Chiang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2527/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-21 16:26:52)
bq.
bq.
bq. Review request for shindig, Ryan Baxter and Dan Dumont.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This patch fix the IE8 rendering issue on both Sample media items gadget
and Sample media items with openGadget API gadget.
bq. All changes are on the gadget code.
bq. Link to JIRA, https://issues.apache.org/jira/browse/SHINDIG-1648
bq.
bq.
bq. This addresses bug SHINDIG-1648.
bq. https://issues.apache.org/jira/browse/SHINDIG-1648
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/media-openGadgets/MediaUIOpenGadgets.js
1187403
bq.
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/media-openGadgets/Social.js
1187403
bq.
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/media/MediaUI.js
1187403
bq.
bq. Diff: https://reviews.apache.org/r/2527/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Test done on the sample container testing with both Firefox and IE8
bq.
bq.
bq. Thanks,
bq.
bq. Jason
bq.
bq.
> Media gadgets does not work on IE8
> ----------------------------------
>
> Key: SHINDIG-1648
> URL: https://issues.apache.org/jira/browse/SHINDIG-1648
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 3.0.0
> Environment: IE Browser
> Reporter: Jason Chiang
> Labels: patch
> Fix For: 3.0.0
>
>
> Both Sample media items gadget and Sample media items with OpenGadget API
> gadget does not render correctly in IE8.
> Link to code review, https://reviews.apache.org/r/2527/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
