[
https://issues.apache.org/jira/browse/SHINDIG-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134209#comment-13134209
]
[email protected] commented on SHINDIG-1647:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2467/
-----------------------------------------------------------
(Updated 2011-10-24 16:28:55.659592)
Review request for Ryan Baxter, Dan Dumont and Jesse Ciancetta.
Changes
-------
Updates based on feedback.
Summary
-------
This patch adds an abstraction layer between implementations and configuration.
The patch consists of an abstract class and some interfaces that are used to
read and observe ContainerConfig. Implementors of this class could decide to
read their configuration from ContainerConfig or provide values from another
source. This also allows code that needs to use configuration to not have to
worry about managing container.js keys. They can simply ask their provider for
values.
I've separated this out from another review as it is generic. To see an
implementation of ValueProvider, you can look at this review:
https://reviews.apache.org/r/2362
This addresses bug SHINDIG-1647.
https://issues.apache.org/jira/browse/SHINDIG-1647
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/config/ValueProvider.java
PRE-CREATION
Diff: https://reviews.apache.org/r/2467/diff
Testing
-------
No specific testing done on the patch, but testing was done in the other review
for those classes that implement and use it.
Thanks,
Stanton
> Provide an abstraction between implementations and the configurations they use
> ------------------------------------------------------------------------------
>
> Key: SHINDIG-1647
> URL: https://issues.apache.org/jira/browse/SHINDIG-1647
> Project: Shindig
> Issue Type: New Feature
> Components: Java
> Affects Versions: 3.0.0
> Reporter: Stanton Sievers
> Fix For: 3.0.0
>
>
> Add an abstraction layer between implementations and configuration. The
> patch consists of an abstract class and some interfaces that are used to read
> and observe ContainerConfig. Implementors of this class could decide to read
> their configuration from ContainerConfig or provide values from another
> source. This also allows code that needs to use configuration to not have to
> worry about managing container.js keys. They can simply ask their provider
> for values.
> I've separated this out from another review as it is generic. To see an
> implementation of ValueProvider, you can look at this review:
> https://reviews.apache.org/r/2362
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
