[
https://issues.apache.org/jira/browse/SHINDIG-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141343#comment-13141343
]
[email protected] commented on SHINDIG-1636:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2648/
-----------------------------------------------------------
(Updated 2011-11-01 17:14:11.549968)
Review request for Ryan Baxter and Dan Dumont.
Summary
-------
This patch is to illustrate the minimal set of changes needed to allow the
BlobCrypterSecurityTokenCodec to have a key provided by the config instead of
needing a key file to be provided.
This addresses bug SHINDIG-1636.
https://issues.apache.org/jira/browse/SHINDIG-1636
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/auth/BlobCrypterSecurityTokenCodecTest.java
1195457
http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1195457
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/BlobCrypterSecurityTokenCodec.java
1195457
Diff: https://reviews.apache.org/r/2648/diff
Testing
-------
None right now. Updated JUnits so they'd pass
Thanks,
Stanton
> Create a mechanism to provide an encryption key to the SecurityToken workflow
> -----------------------------------------------------------------------------
>
> Key: SHINDIG-1636
> URL: https://issues.apache.org/jira/browse/SHINDIG-1636
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Reporter: Stanton Sievers
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Currently,
> org.apache.shindig.auth.BlobCrypterSecurityTokenCodec.loadContainers(ContainerConfig,
> Collection<String>, Map<String, BlobCrypter>, Map<String, String>) reads an
> encryption key from a keyfile to instantiate the BlobCrypter. The keyfile is
> defined in the container.js. An improvement to this behavior would be to
> provide an injectable KeyProvider class that can return the key. This would
> allow the key to reside anywhere instead of in a static keyfile.
> Update:
> The old approach was to provide a KeyProvider class but that turned out to be
> a little too heavy and there was some contention over the best
> implementation. Until there is a consensus on the best way to implement that
> abstraction, we can simply add another config value to the container.js that
> is the key itself and have the codec read and use that value if it exists.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
