[ 
https://issues.apache.org/jira/browse/SHINDIG-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141818#comment-13141818
 ] 

[email protected] commented on SHINDIG-1654:
--------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2640/#review3005
-----------------------------------------------------------


Stanton I am having a problem applying the patch, could you update and 
regenerate the patch?

- Ryan


On 2011-10-31 12:28:02, Stanton Sievers wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2640/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-10-31 12:28:02)
bq.  
bq.  
bq.  Review request for shindig.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  The following lines in shindig.properties have been deprecated in favor of 
defining them in container.js. It seems they were implemented in container.js 
but the old configuration was never removed.
bq.  
bq.  
shindig.content-rewrite.proxy-url=%contextRoot%/gadgets/proxy?container=default&url=
bq.  
shindig.content-rewrite.concat-url=%contextRoot%/gadgets/concat?container=default&
 
bq.  
bq.  
bq.  This addresses bug SHINDIG-1654.
bq.      https://issues.apache.org/jira/browse/SHINDIG-1654
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    
http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties
 1190346 
bq.  
bq.  Diff: https://reviews.apache.org/r/2640/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Build/Junit passed
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Stanton
bq.  
bq.


                
> Remove unused configuration in shindig.properties for proxy and concat urls
> ---------------------------------------------------------------------------
>
>                 Key: SHINDIG-1654
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1654
>             Project: Shindig
>          Issue Type: Bug
>          Components: Java
>    Affects Versions: 3.0.0
>            Reporter: Stanton Sievers
>            Priority: Trivial
>             Fix For: 3.0.0
>
>         Attachments: ConcatProxyPropertiesPatch.txt
>
>   Original Estimate: 12h
>  Remaining Estimate: 12h
>
> The following lines in shindig.properties have been deprecated in favor of 
> defining them in container.js.  It seems they were implemented in 
> container.js but the old configuration was never removed.
> shindig.content-rewrite.proxy-url=%contextRoot%/gadgets/proxy?container=default&url=
> shindig.content-rewrite.concat-url=%contextRoot%/gadgets/concat?container=default&

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to