[
https://issues.apache.org/jira/browse/SHINDIG-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151505#comment-13151505
]
[email protected] commented on SHINDIG-1661:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2851/#review3305
-----------------------------------------------------------
Ship it!
+1
- Henry
On 2011-11-16 14:34:28, li xu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2851/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-16 14:34:28)
bq.
bq.
bq. Review request for shindig and Henry Saputra.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Right now extended javascript features is always loaded first than default
javascript features.
bq. This is okay for normal case. However if we'd like an extended feature to
overwrite an default feature, this would become a problem.
bq. The simple fix would address this issue.
bq.
bq.
bq. This addresses bug SHINDIG-1661.
bq. https://issues.apache.org/jira/browse/SHINDIG-1661
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java
1202451
bq.
bq. Diff: https://reviews.apache.org/r/2851/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. passed junit test.
bq.
bq.
bq. Thanks,
bq.
bq. li
bq.
bq.
> need to load default features before extended feature
> -----------------------------------------------------
>
> Key: SHINDIG-1661
> URL: https://issues.apache.org/jira/browse/SHINDIG-1661
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 3.0.0
> Environment: all
> Reporter: li xu
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: patch_load_feature
>
>
> Right now extended javascript features is always loaded first than default
> javascript features.
> This is okay for normal case. However if we'd like an extended feature to
> overwrite an default feature, this would become a problem.
> The simple fix would address this issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
