[
https://issues.apache.org/jira/browse/SHINDIG-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162439#comment-13162439
]
[email protected] commented on SHINDIG-1664:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2994/#review3609
-----------------------------------------------------------
You might want to test all your feature xml uses changes work when RPC
arbitration is enabled as well.
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-voip.xml
<https://reviews.apache.org/r/2994/#comment8039>
Small nit can we make the spacing consistent here?
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.url/url_site.js
<https://reviews.apache.org/r/2994/#comment8043>
This variable name does name make sense in this case URL sites do not
contain gadgets.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js
<https://reviews.apache.org/r/2994/#comment8046>
Rename this method if we are calling it for URL sites as well
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js
<https://reviews.apache.org/r/2994/#comment8044>
So can I now call this for URL sites as well? If so we should rename the
method
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js
<https://reviews.apache.org/r/2994/#comment8045>
Rename this method because it is no longer for just GadgetSites.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js
<https://reviews.apache.org/r/2994/#comment8042>
Are we sure there are no other assumptions about the sites_ array
containing only GadgetSites?
- Ryan
On 2011-12-02 20:40:53, Dan Dumont wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2994/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-02 20:40:53)
bq.
bq.
bq. Review request for shindig, Ryan Baxter, Jason Chiang, Matthew Hatem, and
Stanton Sievers.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. As a general rule, any time anyone is writing a feature using RPC, those
endpoints should never expect to get a function (or something that contains a
function) as an argument.
bq. The serialization that happens when running with locked domains will null
the function argument when (and only when) in locked domains (so jsunit tests
will pass).
bq.
bq. The check is a bit to expensive to perform for each rpc call so I think
people are just going to have to stay sharp.
bq.
bq. Side note:
bq. The ugly code you'll run into to get the gadget holder from a site is
temporary. I want to go in later and refactor gadget sites, gadget holders,
url sites, and url holders to inherit from a common parent an remove a bunch of
the duplication and make the methods make more sense.
bq.
bq.
bq. This addresses bug SHINDIG-1664.
bq. https://issues.apache.org/jira/browse/SHINDIG-1664
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-voip.xml
1209641
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js
1209641
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js
1209641
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml
1209641
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js
1209641
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.url/url_site.js
1209641
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js
1209641
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/feature.xml
1209641
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/feature.xml
1209641
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js
1209641
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js
1209641
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/feature.xml
1209641
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js
1209641
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js
1209641
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js
1209641
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container.url/url_site_test.js
1209641
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_site_test.js
1209641
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/open-views/viewEnhancements-test.js
1209641
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js
1209641
bq.
bq. Diff: https://reviews.apache.org/r/2994/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated jsunit tests, they all pass.
bq.
bq. Tested with some gadgets to exercise the open-views, selection, and
actions api.
bq.
bq.
bq. Thanks,
bq.
bq. Dan
bq.
bq.
> Actions, selection, and open-views feature issues in a locked domain
> environment.
> ---------------------------------------------------------------------------------
>
> Key: SHINDIG-1664
> URL: https://issues.apache.org/jira/browse/SHINDIG-1664
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Environment: Shindig with locked domains enabled.
> Reporter: Dan Dumont
>
> Inspection of the code reveals that functions were being passed as arguments
> through rpc.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
