[
https://issues.apache.org/jira/browse/SHINDIG-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162489#comment-13162489
]
[email protected] commented on SHINDIG-1667:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3006/
-----------------------------------------------------------
Review request for shindig, Jesse Ciancetta and Brian Lillie.
Summary
-------
After we return from doFetchConcatResources(..) we set the status in doGet. So
lets say we return false from doFetchConcatResources and the content written to
the response was bigger than the buffer. This means we will flush the buffer
and set the status to the OK status then write the rest of the content and set
the status to bad request, but it will be to late we already set the status to
OK
This addresses bug SHINDIG-1667.
https://issues.apache.org/jira/browse/SHINDIG-1667
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ConcatProxyServlet.java
1210178
Diff: https://reviews.apache.org/r/3006/diff
Testing
-------
Ran unit tests and rendered gadgets in common container
Thanks,
Ryan
> ConcatProxyServlet sets the HTTP response status after writing the response
> ---------------------------------------------------------------------------
>
> Key: SHINDIG-1667
> URL: https://issues.apache.org/jira/browse/SHINDIG-1667
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Ryan Baxter
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: fix-1667.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> After we return from doFetchConcatResources(..) we set the status in doGet.
> So lets say we return false from doFetchConcatResources and the content
> written to the response was bigger than the buffer. This means we will flush
> the buffer and set the status to the OK status then write the rest of the
> content and set the status to bad request, but it will be to late we already
> set the status to OK
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
