[
https://issues.apache.org/jira/browse/SHINDIG-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165345#comment-13165345
]
[email protected] commented on SHINDIG-1671:
--------------------------------------------------------
bq. On 2011-12-07 23:13:36, Ryan Baxter wrote:
bq. >
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js,
line 33
bq. > <https://reviews.apache.org/r/3053/diff/2/?file=62850#file62850line33>
bq. >
bq. > I thought we were going to allot this for floats and dialogs?
bq.
bq. Dan Dumont wrote:
bq. I figured we could have this discussion here.
bq.
bq. In the spec language, I would prefer to say that containers SHOULD
consider coordinates passed in to this method if the target is FLOAT. And that
if the target is anything else, containers MAY consider the coordinates.
bq.
bq. Dialogs are a bit heavy weight, and most containers will probably want
to control where they pop up and how they look.
bq. Floats seem to be to be lighter weight, probably with little to no
gadget chrome.
After taking a second look at this, I realized this code was in the EE sample
container, so really the decision over what view types they honor this for is
up to the container, is that correct?
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3053/#review3718
-----------------------------------------------------------
On 2011-12-07 16:53:27, Dan Dumont wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3053/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-07 16:53:27)
bq.
bq.
bq. Review request for shindig, Ryan Baxter, Jason Chiang, and Stanton Sievers.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Also updated the /samplecontainer/examples/embeddedexperiences/ container
and gadgets to demonstrate how one might support the feature.
bq.
bq. A spec update will be written up to account for these changes.
bq.
bq.
bq. This addresses bug SHINDIG-1671.
bq. https://issues.apache.org/jira/browse/SHINDIG-1671
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js
1211472
bq.
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml
1211472
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js
1211478
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/open-views/viewEnhancements-test.js
1211472
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js
1211472
bq.
bq. Diff: https://reviews.apache.org/r/3053/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. all tests pass, added a jsunit test case.
bq.
bq.
bq. Thanks,
bq.
bq. Dan
bq.
bq.
> Update Open View APIs To Support Opening Of Views At Specific Locations
> -----------------------------------------------------------------------
>
> Key: SHINDIG-1671
> URL: https://issues.apache.org/jira/browse/SHINDIG-1671
> Project: Shindig
> Issue Type: Improvement
> Reporter: Dan Dumont
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
