[
https://issues.apache.org/jira/browse/SHINDIG-1672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167712#comment-13167712
]
[email protected] commented on SHINDIG-1672:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3064/#review3850
-----------------------------------------------------------
Ship it!
It looks pretty good to me, thanks for the patch! I can help you commit.
Please clean up following minor things.
1. please fill in the test field and indicate what tests you have done.
2. please clean up the use about Maps. please use
com.google.common.collect.Maps.
3. please fix up the spacing in java, if you use Eclipse IDE, you can find all
the coding style templates under Shindig-project/etc/eclipse
thanks!
li
- li
On 2011-12-12 16:48:18, Doug Davies wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3064/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-12 16:48:18)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. It would be nice if the GrantRequestHandler had access to the original
request object so that it could use values like the security token to pass
along additional params to the authorization code request. In our
implementation we set values within the security token's trusted json field
that we'd like to pass along to our GrantRequestHandler implementation.
bq.
bq.
bq. This addresses bug SHINDIG-1672.
bq. https://issues.apache.org/jira/browse/SHINDIG-1672
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Accessor.java
1212126
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Request.java
1212126
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2RequestParameterGenerator.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Accessor.java
1212126
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Module.java
1212126
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2RequestParameterGenerator.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/BasicAuthenticationHandler.java
1212126
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/ClientCredentialsGrantTypeHandler.java
1212126
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/CodeGrantTypeHandler.java
1212126
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/StandardAuthenticationHandler.java
1212126
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/DefaultRequestPipelineTest.java
1212126
bq.
bq. Diff: https://reviews.apache.org/r/3064/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Doug
bq.
bq.
> The HttpRequest object is not available to GrantRequestHandlers
> ---------------------------------------------------------------
>
> Key: SHINDIG-1672
> URL: https://issues.apache.org/jira/browse/SHINDIG-1672
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 3.0.0
> Reporter: Doug Davies
>
> It would be nice if the GrantRequestHandler had access to the original
> request object so that it could use values like the security token to pass
> along additional params to the authorization code request. In our
> implementation we set values within the security token's trusted json field
> that we'd like to pass along to our GrantRequestHandler implementation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
