[
https://issues.apache.org/jira/browse/SHINDIG-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174173#comment-13174173
]
[email protected] commented on SHINDIG-1675:
--------------------------------------------------------
bq. On 2011-12-20 14:00:30, Ryan Baxter wrote:
bq. >
/trunk/content/samplecontainer/examples/commoncontainer/viewController.js, line
207
bq. > <https://reviews.apache.org/r/3165/diff/2/?file=64332#file64332line207>
bq. >
bq. > I believe jQuery provides a function that we can use instead of eval
The jQuery eval function that I found was..
http://api.jquery.com/jQuery.globalEval/
bq. From the doc..
"This method behaves differently from using a normal JavaScript eval() in that
it's executed within the global context (which is important for loading
external scripts dynamically)."
In this case, I'm not sure if it is necessary or even desirable to allow the
user input to run within the global context but I'm still a mostly novice
JavaScript programmer so I can be easily convinced otherwise. Unless it does
some input sanitizing or something.
- Matt
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3165/#review4011
-----------------------------------------------------------
On 2011-12-21 16:05:37, Matt Marum wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3165/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-21 16:05:37)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. As we start to build (and promote the use of) embedded experience gadgets,
we need to provide easier ways for Gadget developers to quickly prototype these
gadgets. I'd like to add an Embedded Experience Gadgets section to the Common
Container test environment
(http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can
quickly set a Gadget URL and the context to be passed on render.
bq.
bq. This has makes quickly testing EE gadgets much easier.
bq.
bq.
bq. This addresses bug SHINDIG-1675.
bq. https://issues.apache.org/jira/browse/SHINDIG-1675
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/content/samplecontainer/examples/commoncontainer/assembler.js
1220905
bq. /trunk/content/samplecontainer/examples/commoncontainer/cconviews.js
1220905
bq. /trunk/content/samplecontainer/examples/commoncontainer/index.html
1220905
bq.
/trunk/content/samplecontainer/examples/commoncontainer/viewController.js
1220905
bq.
bq. Diff: https://reviews.apache.org/r/3165/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested locally with some EE gadgets I've been building. Andy Smith has
used it too. There are no automated tests for the sample containers.
bq.
bq.
bq. Thanks,
bq.
bq. Matt
bq.
bq.
> Add support for Embedded Experience Gadgets in the CommonContainer test
> environment
> -----------------------------------------------------------------------------------
>
> Key: SHINDIG-1675
> URL: https://issues.apache.org/jira/browse/SHINDIG-1675
> Project: Shindig
> Issue Type: New Feature
> Components: Javascript
> Affects Versions: 3.0.0
> Reporter: Matthew Marum
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: addEEtoCommonContainer.patch
>
>
> As we start to build (and promote the use of) embedded experience gadgets, we
> need to provide easier ways for Gadget developers to quickly prototype these
> gadgets. I'd like to add an Embedded Experience Gadgets section to the
> Common Container test environment
> (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can
> quickly set a Gadget URL and the context to be passed on render.
> This makes quickly testing EE gadgets much easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
