[ 
https://issues.apache.org/jira/browse/SHINDIG-1679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181046#comment-13181046
 ] 

[email protected] commented on SHINDIG-1679:
--------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3402/
-----------------------------------------------------------

Review request for shindig.


Summary
-------

SHINDIG-1669 is not working as expected in all situations and is causing to 
many failures, best to revert it for now until we come up with a better 
solution.  The only file I did not revert is viewenhancements-container.js 
because those changes were for other bugs.


This addresses bug SHINDIG-1679.
    https://issues.apache.org/jira/browse/SHINDIG-1679


Diffs
-----

  
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml
 1227888 
  
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js
 1227888 
  
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js
 1227888 
  
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js
 1227888 
  
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container.url/container_url_test.js
 1227888 

Diff: https://reviews.apache.org/r/3402/diff


Testing
-------

Ran unit tests and tested in the sample common container and embedded 
experiences container.


Thanks,

Ryan


                
> Reverting SHINDIG-1669
> ----------------------
>
>                 Key: SHINDIG-1679
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1679
>             Project: Shindig
>          Issue Type: Bug
>            Reporter: Ryan Baxter
>         Attachments: issue-1679.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> SHINDIG-1669 is not working as expected in all situations and is causing to 
> many failures, best to revert it for now until we come up with a better 
> solution.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to