[
https://issues.apache.org/jira/browse/SHINDIG-1678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191181#comment-13191181
]
[email protected] commented on SHINDIG-1678:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3566/#review4535
-----------------------------------------------------------
Ship it!
LGTM
- Dan
On 2012-01-20 16:53:37, Henry Saputra wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3566/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-20 16:53:37)
bq.
bq.
bq. Review request for shindig and johnfargo.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. See "SHINDIG-1678 The flash transport to support RPC for IE7 has problem
with multiple gadgets in a single container"
https://issues.apache.org/jira/browse/SHINDIG-1678 for detail description about
the review.
bq.
bq. Proposed fix is to flush the handshakes objects whenever new gadgets call
gadgets.rpc.setupReceiver is called to make sure the container side register
the child iframe info to the flash component.
bq.
bq.
bq. This addresses bug SHINDIG-1678.
bq. https://issues.apache.org/jira/browse/SHINDIG-1678
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/features/src/main/javascript/features/rpc/flash.transport.js
1233272
bq.
bq. Diff: https://reviews.apache.org/r/3566/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Running multiple gadgets in common container in IE7
bq.
bq.
bq. Thanks,
bq.
bq. Henry
bq.
bq.
> The flash transport to support RPC for IE7 has problem with multiple gadgets
> in a single container
> --------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1678
> URL: https://issues.apache.org/jira/browse/SHINDIG-1678
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.0.2, 3.0.0
> Reporter: Henry Saputra
> Assignee: Henry Saputra
> Labels: ie7, rpc
>
> The flash rpc transport to support ie7 does not work properly for multiple
> gadgets in a single container. The function flushHandshakes in
> flash.transport.js only called by ready() function which only be called once
> by the flash component after it initialized itself.
> The flash component act as singleton to make sure the main function only
> called once for a page. The transport ready() function which called at the
> end of the main function of the actionscript file hence only called once even
> though multiple gadget call gadgets.rpc.setupReceiver().
> So if a second gadget is in the same container, the flushHandshakes() will
> never be called to setup that gadget iframe.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
