[
https://issues.apache.org/jira/browse/SHINDIG-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191454#comment-13191454
] [email protected] commented on SHINDIG-1683: -------------------------------------------------------- ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3531/#review4539 ----------------------------------------------------------- Ship it! Committed r1234987 - Dan On 2012-01-23 14:19:57, Dan Dumont wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/3531/ bq. ----------------------------------------------------------- bq. bq. (Updated 2012-01-23 14:19:57) bq. bq. bq. Review request for shindig. bq. bq. bq. Summary bq. ------- bq. bq. The diffs did not work out how I had hoped... But they aren't too bad. bq. bq. Only a few apis actually changed names. None of those apis were in the incubating CC spec. bq. Here are the new base classes and methods introduced: bq. <exports type="js">osapi.container.Site</exports> bq. <exports type="js">osapi.container.Site.prototype.onConstructed</exports> bq. <exports type="js">osapi.container.Site.prototype.close</exports> bq. <exports type="js">osapi.container.Site.prototype.setParentId</exports> bq. <exports type="js">osapi.container.Site.prototype.getParentId</exports> bq. <exports type="js">osapi.container.Site.prototype.getActiveSiteHolder</exports> bq. <exports type="js">osapi.container.Site.prototype.getId</exports> bq. <exports type="js">osapi.container.Site.prototype.render</exports> bq. <exports type="js">osapi.container.Site.prototype.setHeight</exports> bq. <exports type="js">osapi.container.Site.prototype.setWidth</exports> bq. bq. <exports type="js">osapi.container.SiteHolder</exports> bq. <exports type="js">osapi.container.SiteHolder.prototype.onConstructed</exports> bq. <exports type="js">osapi.container.SiteHolder.prototype.createIframeAttributeMap</exports> bq. <exports type="js">osapi.container.SiteHolder.prototype.createIframeHtml</exports> bq. <exports type="js">osapi.container.SiteHolder.prototype.dispose</exports> bq. <exports type="js">osapi.container.SiteHolder.prototype.getElement</exports> bq. <exports type="js">osapi.container.SiteHolder.prototype.getIframeElement</exports> bq. <exports type="js">osapi.container.SiteHolder.prototype.getIframeId</exports> bq. <exports type="js">osapi.container.SiteHolder.prototype.getUrl</exports> bq. <exports type="js">osapi.container.SiteHolder.prototype.render</exports> bq. bq. bq. This addresses bug SHINDIG-1683. bq. https://issues.apache.org/jira/browse/SHINDIG-1683 bq. bq. bq. Diffs bq. ----- bq. bq. http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/cconviews.js 1233039 bq. http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1233039 bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1233039 bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/feature.xml 1233039 bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js 1233039 bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1233039 bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/feature.xml PRE-CREATION bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js PRE-CREATION bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_site.js PRE-CREATION bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.url/feature.xml PRE-CREATION bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.url/url_holder.js PRE-CREATION bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.url/url_site.js PRE-CREATION bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site/feature.xml PRE-CREATION bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site/site.js PRE-CREATION bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site/site_holder.js PRE-CREATION bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.url/feature.xml 1233039 bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.url/url_holder.js 1233039 bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.url/url_site.js 1233039 bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1233039 bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1233039 bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/feature.xml 1233039 bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1233039 bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/feature.xml 1233039 bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1233039 bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/opensearch/opensearch.js 1233039 bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shared-script-frame/shared-script-frame-container.js 1233039 bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/alltests.js 1233039 bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container.url/url_holder_test.js 1233039 bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container.url/url_site_test.js 1233039 bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/container_test.js 1233039 bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js 1233039 bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_site_test.js 1233039 bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/embeddedexperiences/embedded_experiences_container_test.js 1233039 bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/opensearch/opensearch_test.js 1233039 bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/lib/testutils.js 1233039 bq. bq. Diff: https://reviews.apache.org/r/3531/diff bq. bq. bq. Testing bq. ------- bq. bq. Fixed up tests, all tests pass. bq. bq. bq. Thanks, bq. bq. Dan bq. bq. > Refactor common container gadget/url sites and holders to use base class > implementations. > ----------------------------------------------------------------------------------------- > > Key: SHINDIG-1683 > URL: https://issues.apache.org/jira/browse/SHINDIG-1683 > Project: Shindig > Issue Type: Improvement > Reporter: Dan Dumont > Attachments: shindig.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
