calling gadgets.window.adjustWidth results in infinite loop
-----------------------------------------------------------

                 Key: SHINDIG-1696
                 URL: https://issues.apache.org/jira/browse/SHINDIG-1696
             Project: Shindig
          Issue Type: Bug
          Components: Javascript 
    Affects Versions: 3.0.0
            Reporter: li xu
            Priority: Minor
             Fix For: 3.0.0


This is a fix from Sarah Brolley. Thanks!

The problem is that it didn't pass in the newWidth when calling adjustWidth in 
the call back function.

 var callback = null;
    if (isNaN(opt_width) && viewportWidth >= newWidth) {
      // Due to quirks in the width property, the auto-calculated width will
      // never be smaller than the size of the viewport. In order to decrease
      // the width to a fit size, we must first make the viewport too small 
(1px),
      // then callback a function that increases the frame to the right width.
      callback = function() {
        gadgets.window.adjustWidth();   ---> FIX: should pass in the new Width 
here
      };
      newWidth = 1;
    }
    gadgets.rpc.call(null, 'resize_iframe_width', callback, newWidth);

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to