[
https://issues.apache.org/jira/browse/SHINDIG-1691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200038#comment-13200038
]
[email protected] commented on SHINDIG-1691:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3695/
-----------------------------------------------------------
(Updated 2012-02-03 21:03:25.952279)
Review request for shindig.
Changes
-------
Another update to the patch. This time much smaller as I stopped trying to move
svn source trees through svn diff patches (which simply doesn't work reliable).
After this patch is applied, the following svn commands need to be executed to
end up with the desired result (from the checkout root folder):
$ svn move --parents java/server/src/main/java
java/sample-container/src/main/java
$ svn move --parents java/server/src/main java/server-resources/src/main
Thanks to Jesse for the suggestion to solve it this way: *much* easier!
Summary
-------
This is an *artificial* patch showing the *end* result of the proposed changes.
These changes assume several source *moves*, which cannot be reliably captured
as an svn diff.
If this patch is accepted, it probably is best to do (part of) the proposed
steps as described in https://issues.apache.org/jira/browse/SHINDIG-1691
manually.
Note: I've created this patch using svn 1.7.2 with (1.7+ only) command
parameters: svn diff --show-copies-as-adds --no-diff-deleted
This addresses bug SHINDIG-1691.
https://issues.apache.org/jira/browse/SHINDIG-1691
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/sample-container/pom.xml
PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/server-dependencies/pom.xml
PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/pom.xml
PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/server/pom.xml 1235579
http://svn.apache.org/repos/asf/shindig/trunk/pom.xml 1235579
Diff: https://reviews.apache.org/r/3695/diff
Testing
-------
Thanks,
Ate
> Maven project enhancements to improve embedding and extending shindig-server
> ----------------------------------------------------------------------------
>
> Key: SHINDIG-1691
> URL: https://issues.apache.org/jira/browse/SHINDIG-1691
> Project: Shindig
> Issue Type: Improvement
> Components: Build, Java
> Affects Versions: 3.0.0
> Reporter: Ate Douma
> Fix For: 3.0.0
>
>
> As proposed on dev@shindig mailing list before, this issue is about
> enhancements for the Maven build configuration and modules to improve
> embedding and extending shindig-server for downstream projects like Apache
> Rave and further.
> The full proposal thread can be found here:
> http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F1F68F8.5010801%40douma.nu%3E
> In short, my proposal is the following, and I'll post a patch for these
> changes up for review shortly:
> a) Move java/server/src/main/java/* (sample container code)
> to new jar module java/sample-container
> b) Move java/server/src/main/webapps/*
> to new (shallow) war module java/server-resources
> c) Move resources currently merged into server module from ./../content and
> ../../config also into new (shallow) war module java/server-resources
> d) Add new pom module java/server-dependencies which (only) defines
> the runtime dependencies needed for the shindig-server module
> Note: this should also add new dependency on shindig-sample-container
> e) The remainder of the shindig-server module then only needs to have
> dependencies on the shindig-server-resources (war overlay) and
> shindig-server-dependencies (pom), as well as some needed test only
> dependencies for the remaining "endtoend" unit-tests
> The end result of the above will again be a shindig-server war equal to the
> current shindig-server war but now downstream users can more easily embed and
> extend it, with proper maven (transitive) dependency resolution support.
> The above changes really are quite trivial and will have zero impact for
> development and current end usages.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
