[
https://issues.apache.org/jira/browse/SHINDIG-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202476#comment-13202476
]
[email protected] commented on SHINDIG-1695:
--------------------------------------------------------
bq. On 2012-02-07 15:10:16, Ryan Baxter wrote:
bq. >
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js,
line 91
bq. > <https://reviews.apache.org/r/3768/diff/3/?file=72708#file72708line91>
bq. >
bq. > Instead of throwing errors could we call the callback with an error?
If the request were even attempted I would say yes, this is just sanity
checking before we start.
bq. On 2012-02-07 15:10:16, Ryan Baxter wrote:
bq. >
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml,
line 35
bq. > <https://reviews.apache.org/r/3768/diff/3/?file=72707#file72707line35>
bq. >
bq. > Seems like this api would fit better in the gadgets.io namespace.
Not sure about how much of gadgets.io Mark want's to deprecate.
Also, currently it seems like the entire io feature is included by core and
always available. To avoid confusion, I wanted to make it separate... though
you're right it is IO.
I saw some talk of how to define what apis are in what features. Not sure
where I really want to put this function. I'll address it later when I get
more feedback from Mark as he does the spec for the feature.
bq. On 2012-02-07 15:10:16, Ryan Baxter wrote:
bq. >
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js,
line 1
bq. > <https://reviews.apache.org/r/3768/diff/3/?file=72708#file72708line1>
bq. >
bq. > To be safe you probably also want to make sure that gadgets is
already defined. I have seen feature code do gadgets.io = gadgets.io || {}.
bq. >
bq. > Also how much of this code is borrowed from the makeRequest code?
I'll look into it.
- Dan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3768/#review4861
-----------------------------------------------------------
On 2012-02-07 14:49:32, Dan Dumont wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3768/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-07 14:49:32)
bq.
bq.
bq. Review request for Ryan Baxter and Stanton Sievers.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. With the desire to deprecate the makeRequest API, we still need a method
to post files through the proxy. This new feature should not be bundled in with
core, it should need to be explicitly requested.
bq.
bq. It should allow modern browsers such as FF and Chrome to monitor form post
progress. It should still be functional (do the post) for less capable browsers
like IE, even though post progress may not be available.
bq.
bq.
bq. This addresses bug SHINDIG-1695.
bq. https://issues.apache.org/jira/browse/SHINDIG-1695
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/config/container.js
1241308
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js
1241308
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js
1241308
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt
1241308
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java
1241308
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java
1241308
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java
1241308
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java
1241308
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java
1241308
bq.
bq. Diff: https://reviews.apache.org/r/3768/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Dan
bq.
bq.
> new core-gadget feature "proxied-form-post" gadgets.proxiedMultipartFormPost
> ----------------------------------------------------------------------------
>
> Key: SHINDIG-1695
> URL: https://issues.apache.org/jira/browse/SHINDIG-1695
> Project: Shindig
> Issue Type: New Feature
> Reporter: Dan Dumont
> Assignee: Dan Dumont
>
> With the desire to deprecate the makeRequest API, we still need a method to
> post files through the proxy. This new feature should not be bundled in with
> core, it should need to be explicitly requested.
> It should allow modern browsers such as FF and Chrome to monitor form post
> progress. It should still be functional (do the post) for less capable
> browsers like IE, even though post progress may not be available.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
