[
https://issues.apache.org/jira/browse/SHINDIG-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207439#comment-13207439
]
[email protected] commented on SHINDIG-1703:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3885/#review5067
-----------------------------------------------------------
Ship it!
LGTM
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/feature.xml
<https://reviews.apache.org/r/3885/#comment11121>
I dont think this is necessary as embedded-experiences already depends on
container, but I don't think it will hurt anything.
- Ryan
On 2012-02-13 22:24:49, Dan Dumont wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3885/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-13 22:24:49)
bq.
bq.
bq. Review request for shindig and Ryan Baxter.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Added a lifecycle listener to handle when sites were closed so that sites
always notify the opener gadget when they close.
bq. Before, sites might not get closed through the open-views feature api, and
that would result in the oper gadget never getting notified.
bq.
bq. Also, we notify the opener gadget even if no result has been set so that
it at least knows the view has been closed.
bq.
bq.
bq. This addresses bug SHINDIG-1703.
bq. https://issues.apache.org/jira/browse/SHINDIG-1703
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/feature.xml
1242959
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js
1242959
bq.
bq. Diff: https://reviews.apache.org/r/3885/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Manual testing with sample gadgets that utilize this feature.
bq.
bq.
bq. Thanks,
bq.
bq. Dan
bq.
bq.
> Open-Views feature: views opened by gadgets do not always have their
> resultCallback called.
> -------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1703
> URL: https://issues.apache.org/jira/browse/SHINDIG-1703
> Project: Shindig
> Issue Type: Bug
> Reporter: Dan Dumont
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
