[ 
https://issues.apache.org/jira/browse/SHINDIG-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209785#comment-13209785
 ] 

jirapos...@reviews.apache.org commented on SHINDIG-1709:
--------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3938/
-----------------------------------------------------------

Review request for shindig.


Summary
-------

If you enable RPC arbitration in a container and you want to allow a set of RPC 
service ids regardless of whether the gadgets has features that uses them, it 
is very difficult to do so. The only way to do this today is to provide your 
own arbitrator function to the common container. Essentially this function will 
do the same thing as the default implementation in the common container except 
have a list of allowed RPC service ids. It would be much easier for consumers 
of the common container to supply a list of allowed RPC service ids for this 
container in the config.


This addresses bug SHINDIG-1709.
    https://issues.apache.org/jira/browse/SHINDIG-1709


Diffs
-----

  
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js
 1245178 
  
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js
 1245178 

Diff: https://reviews.apache.org/r/3938/diff


Testing
-------

Tested in common container


Thanks,

Ryan


                
> The RPC abritration code in the common container should allow you to pass in 
> a list of allowed RPC services for that container.
> -------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SHINDIG-1709
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1709
>             Project: Shindig
>          Issue Type: Improvement
>            Reporter: Ryan Baxter
>
> If you enable RPC arbitration in a container and you want to allow a set of 
> RPC service ids regardless of whether the gadgets has features that uses 
> them, it is very difficult to do so.  The only way to do this today is to 
> provide your own arbitrator function to the common container.  Essentially 
> this function will do the same thing as the default implementation in the 
> common container except have a list of allowed RPC service ids.  It would be 
> much easier for consumers of the common container to supply a list of allowed 
> RPC service ids for this container in the config.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to