[
https://issues.apache.org/jira/browse/SHINDIG-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212614#comment-13212614
]
[email protected] commented on SHINDIG-1710:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3959/#review5240
-----------------------------------------------------------
Ship it!
LGTM should help alot.
- Ryan
On 2012-02-20 14:14:35, Stanton Sievers wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3959/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-20 14:14:35)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. CheckStyle is commented out in the main pom.xml with a todo to re-enable
it. I want to re-enable it and fixup the CheckStyle configuration to match the
best practices on the wiki. It also appears that the CheckStyle configuration
currently in Shindig is an older configuration style - some config has moved in
the file and some attributes have been renamed or invalidated.
bq.
bq. As a followup to this JIRA (or perhaps as part of it), I'd like to fix
some of the more obvious style problems.
bq.
bq. There are some mismatches between the headers in some of the files. I
updated the java.header to match the header provided in the Eclipse template
config, however, this causes mismatches in some existing files whose headers do
not match. This is one of the "obvious style problems" I mentioned above that
I will fix.
bq.
bq. The other obvious things to fix would be trailing whitespace, which can
easily be fixed with a script that runs against all *.java files. If this is
worth fixing, I can do that as well.
bq.
bq.
bq. This addresses bug SHINDIG-1710.
bq. https://issues.apache.org/jira/browse/SHINDIG-1710
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/etc/checkstyle/checkstyle.xml
1291013
bq. http://svn.apache.org/repos/asf/shindig/trunk/etc/checkstyle/java.header
1291013
bq. http://svn.apache.org/repos/asf/shindig/trunk/pom.xml 1291013
bq.
bq. Diff: https://reviews.apache.org/r/3959/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Ran "mvn -Pall,reporting,samples clean install checkstyle:checkstyle" and
examined the checkstyle outputs.
bq.
bq.
bq. Thanks,
bq.
bq. Stanton
bq.
bq.
> Enable CheckStyle plugin during maven build
> -------------------------------------------
>
> Key: SHINDIG-1710
> URL: https://issues.apache.org/jira/browse/SHINDIG-1710
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 2.5.0
> Reporter: Stanton Sievers
> Assignee: Stanton Sievers
> Fix For: 2.5.0
>
>
> CheckStyle is commented out in the main pom.xml with a todo to re-enable it.
> I want to re-enable it and fixup the CheckStyle configuration to match the
> best practices on the wiki. It also appears that the CheckStyle
> configuration currently in Shindig is an older configuration style - some
> config has moved in the file and some attributes have been renamed or
> invalidated.
> As a followup to this JIRA (or perhaps as part of it), I'd like to fix some
> of the more obvious style problems.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
