[
https://issues.apache.org/jira/browse/SHINDIG-1450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220291#comment-13220291
]
[email protected] commented on SHINDIG-1450:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3773/#review5514
-----------------------------------------------------------
Ship it!
Committed revision 1295757. Thanks Brian.
- Stanton
On 2012-03-01 19:23:15, BrianLillie wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3773/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-01 19:23:15)
bq.
bq.
bq. Review request for Jesse Ciancetta and Stanton Sievers.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. If a gadget does a makeRequest with method GET and REFRESH_INTERVAL = 0,
the request is issued from the browser as a POST with no refresh interval, and
results in the default caching interval used on the server. The POST prevents
the browser caching, but the refresh interval also should be set to prevent the
server caching, which I believe is the intended behavior.
bq.
bq.
bq. This addresses bug SHINDIG-1450.
bq. https://issues.apache.org/jira/browse/SHINDIG-1450
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js
1241007
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js
1241475
bq.
bq. Diff: https://reviews.apache.org/r/3773/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Modified iotest.js and rest are passing
bq.
bq.
bq. Thanks,
bq.
bq. BrianLillie
bq.
bq.
> io argument REFRESH_INTERVAL=0 is ignored
> -----------------------------------------
>
> Key: SHINDIG-1450
> URL: https://issues.apache.org/jira/browse/SHINDIG-1450
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Reporter: Randy Hudson
> Attachments: zeroRefresh.txt
>
>
> To prevent the bogus behavior of caching request responses for 1 hour, we are
> setting REFRESH_INTERVAL to 0. But shindig and iGoogle seem to be ignoring
> values less than 1:
> code from io.js:
> if (httpMethod === "GET" && refreshInterval > 0) {
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
