[
https://issues.apache.org/jira/browse/SHINDIG-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yao Zhang updated SHINDIG-1723:
-------------------------------
Description:
When trying to load gadgets, the navigateGadgetHandler never gets called
because the runAction function receives an empty array when it calls the
registry.getGadgetSites instead of "undefined", which is what it receives when
gadget loading works in earlier builds. Therefore, the first section in "if
(!gadgetSites)" below doesn't get run and instead it incorrectly goes to the
"else". .getGadgetSites appears to now always return an array and it will be
empty if there aren't any sites instead of "undefined" like in the past.
runAction: function(actionId, opt_selection) {
var action = registry.getItemById(actionId);
if (action) {
// if gadget site has not been registered yet
// the gadget needs to be rendered
var gadgetSites = registry.getGadgetSites(actionId);
if (!gadgetSites) {
var gadgetUrl = registry.getUrl(actionId);
pendingActions[actionId] = {
selection: opt_selection || container_.selection.getSelection()
};
// set optional params
......
},
was:
When trying to load inline gadgets, the navigateGadgetHandler never gets called
because the runAction function receives an empty array when it calls the
registry.getGadgetSites instead of "undefined", which is what it receives when
gadget loading works in earlier builds. Therefore, the first section in "if
(!gadgetSites)" below doesn't get run and instead it incorrectly goes to the
"else". .getGadgetSites appears to now always return an array and it will be
empty if there aren't any sites instead of "undefined" like in the past.
runAction: function(actionId, opt_selection) {
var action = registry.getItemById(actionId);
if (action) {
// if gadget site has not been registered yet
// the gadget needs to be rendered
var gadgetSites = registry.getGadgetSites(actionId);
if (!gadgetSites) {
var gadgetUrl = registry.getUrl(actionId);
pendingActions[actionId] = {
selection: opt_selection || container_.selection.getSelection()
};
// set optional params
......
},
> navigateGadgetHandler never gets called because the runAction function in
> action_container.js receives an empty array when it calls the
> registry.getGadgetSites instead of "undefined",
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1723
> URL: https://issues.apache.org/jira/browse/SHINDIG-1723
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.5.0
> Reporter: Yao Zhang
>
> When trying to load gadgets, the navigateGadgetHandler never gets called
> because the runAction function receives an empty array when it calls the
> registry.getGadgetSites instead of "undefined", which is what it receives
> when gadget loading works in earlier builds. Therefore, the first section in
> "if (!gadgetSites)" below doesn't get run and instead it incorrectly goes to
> the "else". .getGadgetSites appears to now always return an array and it
> will be empty if there aren't any sites instead of "undefined" like in the
> past.
> runAction: function(actionId, opt_selection) {
> var action = registry.getItemById(actionId);
> if (action) {
> // if gadget site has not been registered yet
> // the gadget needs to be rendered
> var gadgetSites = registry.getGadgetSites(actionId);
> if (!gadgetSites) {
> var gadgetUrl = registry.getUrl(actionId);
> pendingActions[actionId] = {
> selection: opt_selection || container_.selection.getSelection()
> };
> // set optional params
> ......
> },
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
