[
https://issues.apache.org/jira/browse/SHINDIG-1727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228934#comment-13228934
]
[email protected] commented on SHINDIG-1727:
--------------------------------------------------------
bq. On 2012-03-13 20:28:04, Stanton Sievers wrote:
bq. >
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js,
line 74
bq. > <https://reviews.apache.org/r/4310/diff/2/?file=91746#file91746line74>
bq. >
bq. > Before when this wasn't being returned, what did that affect? Did
that only mean the selection wasn't available in the callback to the register
rpc call?
I added the callback and the return so that initial selection would be
published to the gadget without calling a selection changed listener (cause it
didn't change, the gadget just didn't have it yet).
- Dan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4310/#review5892
-----------------------------------------------------------
On 2012-03-13 18:36:35, Dan Dumont wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4310/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-13 18:36:35)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Updated sample gadgets.
bq. Added a dummy listener to the selection queue so that a gadget will always
watch selection.
bq. Selection registration now returns the current selection so that gadgets
can prime their selection cache.
bq.
bq.
bq. This addresses bug SHINDIG-1727.
bq. https://issues.apache.org/jira/browse/SHINDIG-1727
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-changer.xml
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-listener.xml
1300267
bq.
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-query.xml
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js
1300267
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js
1300267
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js
1300267
bq.
bq. Diff: https://reviews.apache.org/r/4310/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated and ran unit tests.
bq. Updated sample gadgets, ran sample gadgets in the sample container.
bq.
bq.
bq. Thanks,
bq.
bq. Dan
bq.
bq.
> gadgets.selection.getSelection() does not return current selection on initial
> loading of gadget
> -----------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1727
> URL: https://issues.apache.org/jira/browse/SHINDIG-1727
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Environment: Windows 7
> Reporter: Bernadette Alexia Carter
> Assignee: Dan Dumont
>
> 1) Load first gadget
> 2) Set a selection in the first gadget using gadgets.selection.setSelection
> 3) Load second gadget
> 4) do a gadgets.selection.getSelection in second gadget
> Expected: gadgets.selection.getSelection returns selection made in first
> gadget
> Actual: gadgets.selection.getSelection returns undefined
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
