[
https://issues.apache.org/jira/browse/SHINDIG-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232594#comment-13232594
]
[email protected] commented on SHINDIG-1736:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4366/#review6070
-----------------------------------------------------------
Ship it!
LGTM
- Ryan
On 2012-03-15 17:47:31, Doug Davies wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4366/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-15 17:47:31)
bq.
bq.
bq. Review request for shindig and Paul Lindner.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is a fix for SHINDIG-1736. Currently the recently updated JsonUtil
blows up if the class it is trying to parse has synthetic methods generated by
the compiler for handling runtime generics substitution. It now checks to make
sure the method is not synthetic. I've included a unit test that tests this
scenario.
bq.
bq.
bq. This addresses bug SHINDIG-1736.
bq. https://issues.apache.org/jira/browse/SHINDIG-1736
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/java/common/src/main/java/org/apache/shindig/common/JsonUtil.java
1299867
bq.
/trunk/java/common/src/test/java/org/apache/shindig/common/JsonUtilTest.java
1299867
bq.
bq. Diff: https://reviews.apache.org/r/4366/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. unit test provided
bq.
bq.
bq. Thanks,
bq.
bq. Doug
bq.
bq.
> JsonUtil throws IllegalArgumentException if the class it is parsing has any
> duplicate methods
> ---------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1736
> URL: https://issues.apache.org/jira/browse/SHINDIG-1736
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.5.0
> Reporter: Doug Davies
>
> JsonUtil throws
> java.lang.IllegalArgumentException: duplicate key: value
> if the class it is parsing has duplicate methods caused by synthetic methods
> creating for generics. For example:
> private class DuplicateBase<type> {
> public type getValue() {
> return null;
> }
> }
> private class Duplicate extends DuplicateBase<String> {
> public String getValue() {
> return "duplicate";
> }
> }
> If the Duplicate Class is parsed by JsonUtil is will blow up.
> This was introduced by revision 1290973. Before that it did not use the
> guava collection and have this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
