[
https://issues.apache.org/jira/browse/SHINDIG-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233363#comment-13233363
]
[email protected] commented on SHINDIG-1728:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4273/#review6115
-----------------------------------------------------------
Ship it!
Committed revision 1302848.
- Stanton
On 2012-03-19 17:43:45, Stanton Sievers wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4273/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-19 17:43:45)
bq.
bq.
bq. Review request for shindig, Dan Dumont and Adam Clarke.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Currently I can use gadgets.io.makeRequest to do a PUT but the PUT body
does not reach the destination. This works today for POST, it simply seems that
PUT was left out of that implementation.
bq.
bq.
bq. This addresses bug SHINDIG-1728.
bq. https://issues.apache.org/jira/browse/SHINDIG-1728
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java
1302537
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java
1302537
bq.
bq. Diff: https://reviews.apache.org/r/4273/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Stanton
bq.
bq.
> gadgets.io.makeRequest supports PUT but the PUT body is not passed along
> ------------------------------------------------------------------------
>
> Key: SHINDIG-1728
> URL: https://issues.apache.org/jira/browse/SHINDIG-1728
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.5.0
> Reporter: Stanton Sievers
> Assignee: Stanton Sievers
> Fix For: 2.5.0
>
> Attachments: MakeRequestPut.patch
>
>
> Currently I can use gadgets.io.makeRequest to do a PUT but the PUT body does
> not reach the destination. This works today for POST, it simply seems that
> PUT was left out of that implementation.
> This issue is a regression that was caused by this fix to enable form POSTing
> through the proxy. https://issues.apache.org/jira/browse/SHINDIG-1695
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
