[ 
https://issues.apache.org/jira/browse/SHINDIG-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul Lindner closed SHINDIG-1476.
---------------------------------


part of 2.5.0-beta1 release.

                
> TabSet feature left/right scroll elements don't stop propagation of the click 
> event
> -----------------------------------------------------------------------------------
>
>                 Key: SHINDIG-1476
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1476
>             Project: Shindig
>          Issue Type: Bug
>          Components: Javascript 
>    Affects Versions: 2.0.2
>            Reporter: Mat Mannion
>            Priority: Minor
>             Fix For: 2.0.3, 2.5.0-beta1
>
>         Attachments: shindig-1476.patch
>
>
> The TabSet feature doesn't stop propagation of the click events on the left 
> and right arrows when there are too many tabs to display in a line. This is, 
> for the most part, ok - the browser sees that the link is javascript:void(0) 
> and simply no-ops. However, in our Shindig implementation we set a default 
> target attribute on the base tag (i.e. <base href="gadget.xml" 
> target="_blank">) and in Firefox and IE clicking the scrollers causes a new 
> window to be opened and switched to. This is, obviously, not ideal. Chrome is 
> unaffected because it realises that javascript:void(0) is still a no-op in a 
> new window.
> We should .stopPropagation() and .preventDefault() on the event in the 
> onclick (and the equivalent code for IE) in the tab JS feature, so that this 
> problem can't arise. All we are doing is preventing the browser from 
> executing the no-op void(0).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to