[ 
https://issues.apache.org/jira/browse/SHINDIG-1452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul Lindner closed SHINDIG-1452.
---------------------------------


part of 2.5.0-beta1 release.

                
> Allow FeedProcessor to be swapped out via Guice injection
> ---------------------------------------------------------
>
>                 Key: SHINDIG-1452
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1452
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java
>    Affects Versions: 2.0.0
>            Reporter: Bill Wolcken
>            Priority: Minor
>             Fix For: 2.5.0-beta1
>
>         Attachments: 
> 0001-Convert-FeedProcessor-to-an-interface-and-allow-for-.patch
>
>
> Many classes within Shindig can be easily swapped out and replaced by 
> container implementations via Guice injection.  FeedProcessor is not one of 
> them, since HttpRequestHandler and MakeRequestHandler directly instantiate 
> instances of FeedProcessor.  To allow FeedProcessor to be swapped out, 
> FeedProcessor should be replaced with an interface/implementation pair, and 
> HttpRequestHandler and MakeRequestHandler should accept a FeedProcessor 
> Provider as a constructor argument.
> I have made the above described changes against the 2.0.x baseline in the 
> Shindig project fork used by Eureka Streams.  I will attempt to upload and 
> attach a git patch file for the changes.  (The fork also had prior changes to 
> FeedProcessor to support feed images, so that additional feature comes along 
> too.)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to