[
https://issues.apache.org/jira/browse/SHINDIG-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252704#comment-13252704
]
[email protected] commented on SHINDIG-1707:
--------------------------------------------------------
bq. On 2012-04-12 17:42:54, Henry Saputra wrote:
bq. > Could you take a look at the
RenderingGadgetRewriter.injectFeatureLibraries() method? Looks like its trying
to get "libs" from context. For HTML based gadget the libs in the URL could
just be colon separated feature names I believe.
bq.
bq. Dan Dumont wrote:
bq. I'm not sure I want to change the behavior of non url type gadgets.
The arguments in an html gadget aren't specced, for the most part, as shindig
implements all the feature code that uses them. The url type gadgets though
require us to identify key ones that must be there and useful. I am curious
now to see if the feature detection libraries need to be updated for url
gadgets. I'll check in to that.
bq.
bq. Did I miss your point? I can hop on gchat if you think that would be
easier.
I tested loading and using the open-views feature and it works, but there are
some apis that malfunction.
gadgets.util.hasFeature('open-views') is a call that does not work correctly in
url gadgets. The reason for this is not due to my change, but because we don't
have a way to do the config injection for url type gadgets. Tossed some ideas
back and forth with Stanton for a few minutes, there may be something we can do
if libs= param were a multi-url param. Then we might send a link to the
config, I'm not super crazy about that approach and I'd like to see if we
couldn't let the gadgets obtain config from the container page over rpc
instead... anyway... this isn't the time or place for these talks, I'll open a
JIRA for the config issue and that can be assigned as we think is appropriate.
- Dan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4710/#review6893
-----------------------------------------------------------
On 2012-04-12 13:34:54, Dan Dumont wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4710/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-12 13:34:54)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Fix shindig to implement the stated spec, that the libs param should be a
url to download feature impl, not just a list of features.
bq.
bq. Additional conversation on the spec list here:
https://groups.google.com/d/topic/opensocial-and-gadgets-spec/7lGzhk67nY8/discussion
bq.
bq.
bq. This addresses bug SHINDIG-1707.
bq. https://issues.apache.org/jira/browse/SHINDIG-1707
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/url-gadget-with-features/url.html
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/url-gadget-with-features/url.xml
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java
1311965
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManagerTest.java
1311965
bq.
bq. Diff: https://reviews.apache.org/r/4710/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated unit tests to expect the new url.
bq. All tests pass.
bq.
bq. Added a sample url gadget and html page to show the feature working.
bq.
bq.
bq. Thanks,
bq.
bq. Dan
bq.
bq.
> Path To JS Servlet Not Passed As Param For Gadgets Of Type URL
> --------------------------------------------------------------
>
> Key: SHINDIG-1707
> URL: https://issues.apache.org/jira/browse/SHINDIG-1707
> Project: Shindig
> Issue Type: Bug
> Reporter: Ryan Baxter
> Assignee: Dan Dumont
>
> When Shindig renders views of gadgets of type URL, certain parameters are
> passed that should allow the application at that URL to request the
> javascript for the features the gadget uses. (See
> http://opensocial-resources.googlecode.com/svn/spec/2.0/Core-Gadget.xml#rfc.section.3.4)
> Today you get the host of the server and the features the gadget uses, but
> you do not get the path to the JS servlet. Since the servlet can be
> configured in the web.xml it is possible that the path is different depending
> on the instance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
