[
https://issues.apache.org/jira/browse/SHINDIG-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254984#comment-13254984
]
[email protected] commented on SHINDIG-1749:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4738/#review6949
-----------------------------------------------------------
Ship it!
LGTM
- Ryan
On 2012-04-16 16:33:28, Stanton Sievers wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4738/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-16 16:33:28)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. I'm always up for recommendations on how to best log these details. I
considered refactoring this logging to get some re-use. Does anyone think it's
worth it?
bq.
bq. From JIRA:
bq.
bq. If in the process of preloading or navigating a gadget something fails,
the common container will log warnings, "Failed to preload gadget <gadget
url>." and "Failed to navigate for gadget <gadget url>.", respectively.
However, it only logs these errors upon the existence of the "error" object in
the response. It does not log any of the information contained within the
"error" object.
bq.
bq. The proposed improvement would be to log the detailed information in the
"error" object. This includes both the HTTP status code and a detailed message.
This information is more usable when trying to determine the root cause of the
error.
bq.
bq.
bq. This addresses bug SHINDIG-1749.
bq. https://issues.apache.org/jira/browse/SHINDIG-1749
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_site.js
1324773
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js
1324773
bq.
bq. Diff: https://reviews.apache.org/r/4738/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested in the sample common container page. Executed "Preload and Add",
"Add only", and "Preload only" actions for a gadget url that didn't exist.
Verified that the detailed 404 message was logged in all cases.
bq.
bq. "Detailed error: 404 Unable to retrieve spec for
http://localhost:8080/samplecontainer/examples/NonExistent.xml. HTTP error 404"
bq.
bq.
bq. Thanks,
bq.
bq. Stanton
bq.
bq.
> Common Container should log detailed error messages when a gadget fails to
> navigate or preload
> ----------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1749
> URL: https://issues.apache.org/jira/browse/SHINDIG-1749
> Project: Shindig
> Issue Type: Improvement
> Components: Javascript
> Affects Versions: 2.5.0
> Reporter: Stanton Sievers
> Assignee: Stanton Sievers
> Fix For: 2.5.0
>
>
> If in the process of preloading or navigating a gadget something fails, the
> common container will log warnings, "Failed to preload gadget <gadget url>."
> and "Failed to navigate for gadget <gadget url>.", respectively. However, it
> only logs these errors upon the existence of the "error" object in the
> response. It does not log any of the information contained within the
> "error" object.
> The proposed improvement would be to log the detailed information in the
> "error" object. This includes both the HTTP status code and a detailed
> message. This information is more usable when trying to determine the root
> cause of the error.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
