[
https://issues.apache.org/jira/browse/SHINDIG-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256047#comment-13256047
]
[email protected] commented on SHINDIG-1677:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4760/
-----------------------------------------------------------
Review request for shindig.
Summary
-------
Fix the REST endpoints to follow the latest OpenSocial specs to wrap collection
with "list" element.
This addresses bug SHINDIG-1677.
https://issues.apache.org/jira/browse/SHINDIG-1677
Diffs
-----
trunk/java/common/src/main/java/org/apache/shindig/common/util/FutureUtil.java
1326759
trunk/java/common/src/main/java/org/apache/shindig/protocol/JsonRpcServlet.java
1326759
trunk/java/common/src/main/java/org/apache/shindig/protocol/RestfulCollection.java
1326759
trunk/java/common/src/main/java/org/apache/shindig/protocol/conversion/xstream/RestfullCollectionConverter.java
1326759
trunk/java/common/src/test/java/org/apache/shindig/protocol/RestfulCollectionTest.java
1326759
trunk/java/social-api/src/main/java/org/apache/shindig/social/core/util/atom/AtomFeed.java
1326759
trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulJsonActivityTest.java
1326759
trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulJsonPeopleTest.java
1326759
trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulXmlActivityTest.java
1326759
trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulXmlPeopleTest.java
1326759
trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonDelete.json
1326759
trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonGroup.json
1326759
trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonIds.json
1326759
trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryXmlIds.xml
1326759
trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java
1326759
trunk/java/social-api/src/test/resources/org/apache/shindig/social/opensocial/util/opensocial.xsd
1326759
Diff: https://reviews.apache.org/r/4760/diff
Testing
-------
Fixed unit tests for collection and passed the unit tests for single element.
Thanks,
Henry
> Fix the REST response for collection to wrap it with "list" field
> -----------------------------------------------------------------
>
> Key: SHINDIG-1677
> URL: https://issues.apache.org/jira/browse/SHINDIG-1677
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.0.0, 2.5.0-beta1, 2.5.0
> Reporter: Henry Saputra
> Assignee: Henry Saputra
> Labels: apis, collection, opensocial, rest
> Fix For: 2.5.0
>
> Attachments: SHINDIG-1677.patch
>
>
> From the data spec 2.0, collection field need to be wrapped with "list"
> filed. The JSON-RPC endpoints already doing it correctly but the REST
> endpoints response havent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
