[
https://issues.apache.org/jira/browse/SHINDIG-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256411#comment-13256411
]
[email protected] commented on SHINDIG-1540:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4786/
-----------------------------------------------------------
Review request for shindig.
Summary
-------
line 172 in MessageBundle.java:
"message.put(name, sw.toString().trim())"
The "trim()" method trim the whitespace around the message's value, which
result in returning the wrong value.
This addresses bug SHINDIG-1540.
https://issues.apache.org/jira/browse/SHINDIG-1540
Diffs
-----
Diff: https://reviews.apache.org/r/4786/diff
Testing
-------
Done
Thanks,
Ran
> Message string in MessageBundle gets mangled (trimmed) in shindig
> -----------------------------------------------------------------
>
> Key: SHINDIG-1540
> URL: https://issues.apache.org/jira/browse/SHINDIG-1540
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Reporter: Randy Hudson
> Attachments: shindig-1540.patch
>
>
> I have a gadget whose message bundle includes the following entry:
> <msg name="orange" desc="Color, approximately #E69B1E">
> orange
> </msg>
> The value of that message should be "\norange\n", but shindig appears to be
> trimming the whitespace around the message's value.
> Shindig is not following the spec, which states that the msg element extends
> xs:string, and NOT xs:normalizedString:
> <xs:element name="messagebundle">
> <xs:complexType>
> <xs:sequence>
> <xs:element name="msg" minOccurs="0" maxOccurs="unbounded">
> <xs:complexType>
> <xs:simpleContent>
> <xs:extension base="xs:string">
> <xs:attribute name="name" type="xs:string" use="required"/>
> <xs:attribute name="desc" type="xs:string" use="optional"/>
> </xs:extension>
> </xs:simpleContent>
> </xs:complexType>
> </xs:element>
> </xs:sequence>
> </xs:complexType>
> </xs:element>
> See:
> http://www.w3schools.com/Schema/schema_dtypes_string.asp
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
